Defer more renderTargetContexts in the GPU image filter paths - take 2

Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed: https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606

--------------------------------------------------------------------
This CL was partially reverted in:

https://skia-review.googlesource.com/c/5441/ (Remove use of makeDeferredRenderTargetContextWithFallback)
https://skia-review.googlesource.com/c/5541/ (Second part of piecemeal revert)

The second revert CL identified the change that caused the perf regression in crbug.com/668179 so the first CL was reverted/relanded in:

https://skia-review.googlesource.com/c/5573/ (Revert "Remove use of makeDeferredRenderTargetContextWithFallback")

[robertphillips, 2016-11-17 19:58:31]

Description was changed from

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths)
==========

to

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002
==========

[robertphillips, 2016-11-17 20:38:24]

Description was changed from

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths)
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002
==========

to

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com
==========

[robertphillips, 2016-11-17 20:38:24]

robertphillips@google.com changed reviewers:
+ bsalomon@google.com

[robertphillips, 2016-11-17 20:39:17]

Description was changed from

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths)

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com
==========

to

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com
==========

[robertphillips, 2016-11-17 20:39:27]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-17 20:39:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-17 21:26:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-17 21:26:37]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-11-21 18:15:44]

The CQ bit was checked by robertphillips@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-11-21 18:15:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robertphillips, 2016-11-21 18:23:14]

You are welcome to take another look but all of the new changes are updating to
ToT and adding some bullet-proofing for instantiate failures lower down in the
call stack.

[bsalomon, 2016-11-21 18:51:07]

lgtm

[commit-bot: I haz the power, 2016-11-21 18:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 18:59:48]

Dry run: This issue passed the CQ dry run.

[robertphillips, 2016-11-21 19:01:50]

The CQ bit was checked by robertphillips@google.com

[commit-bot: I haz the power, 2016-11-21 19:02:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:05:04]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1479754910492400,
"parent_rev": "43c847b7f281c071a33980359e4d5839855da20f", "commit_rev":
"d728f0c1a94fe926b59d8ebc9ae174019ccd3606"}

[commit-bot: I haz the power, 2016-11-21 19:05:06]

Description was changed from

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com
==========

to

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606
==========

[commit-bot: I haz the power, 2016-11-21 19:05:07]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606

[robertphillips, 2016-12-05 13:21:15]

Description was changed from

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606
==========

to

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606

This CL was partially reverted in:

https://skia-review.googlesource.com/c/5441/ (Remove use of
makeDeferredRenderTargetContextWithFallback)
https://skia-review.googlesource.com/c/5541/ (Second part of piecemeal revert)

The second revert CL identified the change that caused the perf regression in
crbug.com/668179 so the first CL was relanded in:

https://skia-review.googlesource.com/c/5573/ (Revert "Remove use of
makeDeferredRenderTargetContextWithFallback")
==========

[robertphillips, 2016-12-05 13:21:31]

Description was changed from

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606

This CL was partially reverted in:

https://skia-review.googlesource.com/c/5441/ (Remove use of
makeDeferredRenderTargetContextWithFallback)
https://skia-review.googlesource.com/c/5541/ (Second part of piecemeal revert)

The second revert CL identified the change that caused the perf regression in
crbug.com/668179 so the first CL was relanded in:

https://skia-review.googlesource.com/c/5573/ (Revert "Remove use of
makeDeferredRenderTargetContextWithFallback")
==========

to

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606

--------------------------------------------------------------------
This CL was partially reverted in:

https://skia-review.googlesource.com/c/5441/ (Remove use of
makeDeferredRenderTargetContextWithFallback)
https://skia-review.googlesource.com/c/5541/ (Second part of piecemeal revert)

The second revert CL identified the change that caused the perf regression in
crbug.com/668179 so the first CL was relanded in:

https://skia-review.googlesource.com/c/5573/ (Revert "Remove use of
makeDeferredRenderTargetContextWithFallback")
==========

[robertphillips, 2016-12-05 13:22:04]

Description was changed from

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606

--------------------------------------------------------------------
This CL was partially reverted in:

https://skia-review.googlesource.com/c/5441/ (Remove use of
makeDeferredRenderTargetContextWithFallback)
https://skia-review.googlesource.com/c/5541/ (Second part of piecemeal revert)

The second revert CL identified the change that caused the perf regression in
crbug.com/668179 so the first CL was relanded in:

https://skia-review.googlesource.com/c/5573/ (Revert "Remove use of
makeDeferredRenderTargetContextWithFallback")
==========

to

==========
Defer more renderTargetContexts in the GPU image filter paths - take 2

This is a reland of https://skia-review.googlesource.com/c/4767/ (Defer more
renderTargetContexts in the GPU image filter paths).
The addition of guards on instantiation && accessRenderTarget failure should
prevent a reoccurence of this Nexus7 failures.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2514543002

TBR=bsalomon@google.com

Committed:
https://skia.googlesource.com/skia/+/d728f0c1a94fe926b59d8ebc9ae174019ccd3606

--------------------------------------------------------------------
This CL was partially reverted in:

https://skia-review.googlesource.com/c/5441/ (Remove use of
makeDeferredRenderTargetContextWithFallback)
https://skia-review.googlesource.com/c/5541/ (Second part of piecemeal revert)

The second revert CL identified the change that caused the perf regression in
crbug.com/668179 so the first CL was reverted/relanded in:

https://skia-review.googlesource.com/c/5573/ (Revert "Remove use of
makeDeferredRenderTargetContextWithFallback")
==========