update ContextManager to support analysis option include directive

update ContextManager to support analysis option include directive

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/9ec75473230b8d30c69519beef3b5b24ac96b82c

[danrubel, 2016-11-17 19:55:49]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-11-17 20:06:42]

lgtm

https://codereview.chromium.org/2514533002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/2514533002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:687: new
ContextBuilder(resourceProvider, null, null)
Take a look at ContextManagerCallbacks.createContextBuilder. If it's possible to
keep one location where the builder is getting created that would be better. If
not, that's OK too.

[danrubel, 2016-11-17 20:36:38]

Description was changed from

==========
update ContextManager to support analysis option include directive
==========

to

==========
update ContextManager to support analysis option include directive

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/9ec75473230b8d30c69519beef3b5b24ac96b82c
==========

[danrubel, 2016-11-17 20:36:40]

Committed patchset #2 (id:20001) manually as
9ec75473230b8d30c69519beef3b5b24ac96b82c (presubmit successful).

[danrubel, 2016-11-17 20:43:40]

https://codereview.chromium.org/2514533002/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/context_manager.dart (right):

https://codereview.chromium.org/2514533002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/context_manager.dart:687: new
ContextBuilder(resourceProvider, null, null)
On 2016/11/17 20:06:42, Brian Wilkerson wrote:
> Take a look at ContextManagerCallbacks.createContextBuilder. If it's possible
to
> keep one location where the builder is getting created that would be better.
If
> not, that's OK too.

I'll leave this as is because this is temporary code. Long term, the
ContextManager should be reading the options as part of building the context.