Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(147)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/api_test/messaging/on_unload/content_script.js
Issue
2514523002
:
[Extensions] Make port creation synchronous in unload handlers (Closed)
Patch Set:
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/extensions/extension_messages_apitest.cc
chrome/browser/renderer_host/chrome_extension_message_filter.h
chrome/browser/renderer_host/chrome_extension_message_filter.cc
chrome/test/data/extensions/api_test/messaging/on_unload/content_script.js
chrome/test/data/extensions/api_test/messaging/on_unload/manifest.json
chrome/test/data/extensions/api_test/messaging/on_unload/test.js
extensions/common/extension_messages.h
extensions/renderer/extension_frame_helper.h
extensions/renderer/extension_frame_helper.cc
extensions/renderer/messaging_bindings.h
extensions/renderer/messaging_bindings.cc
third_party/WebKit/Source/web/WebDocument.cpp
third_party/WebKit/public/web/WebDocument.h
tools/metrics/histograms/histograms.xml
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/renderer_host/chrome_extension_message_filter.cc
('k') |
chrome/test/data/extensions/api_test/messaging/on_unload/manifest.json »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 The Chromium Authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
window.addEventListener('unload', function() {
6
chrome.runtime.sendMessage('Unloading');
7
});
8
9
chrome.test.sendMessage('listening');
OLD
NEW
« no previous file with comments
|
« chrome/browser/renderer_host/chrome_extension_message_filter.cc
('k') |
chrome/test/data/extensions/api_test/messaging/on_unload/manifest.json »
('j') |
no next file with comments »
Issue 2514523002: [Extensions] Make port creation synchronous in unload handlers (Closed)
Created 4 years, 1 month ago by Devlin
Modified 4 years, 1 month ago
Reviewers:
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2514523002:
[Extensions] Make port creation synchronous in unload handlers (Closed)
