Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 2514473002: [Telemetry] Decrease WPR port logging. (Closed)

Created:
4 years, 1 month ago by rnephew (Reviews Here)
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Decrease WPR port logging. Currently it is not uncommon for this log message to be present 500+ times in a log. Of those the majority are useless because nothing has been done yet. Real example: 630 instances of WPR ports: <anything> 447 instances of WPR ports: {} BUG=chromium:666040 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/22f8db35661ba8938043c1b3af33a962b6c588ef

Patch Set 1 #

Total comments: 3

Patch Set 2 : Move logging message out of IsStarted #

Patch Set 3 : Fix Bug #

Patch Set 4 : Get rid of unneeded call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M telemetry/telemetry/internal/util/wpr_server.py View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
rnephew (Reviews Here)
https://codereview.chromium.org/2514473002/diff/1/telemetry/telemetry/internal/util/wpr_server.py File telemetry/telemetry/internal/util/wpr_server.py (right): https://codereview.chromium.org/2514473002/diff/1/telemetry/telemetry/internal/util/wpr_server.py#newcode220 telemetry/telemetry/internal/util/wpr_server.py:220: atexit_with_log.Register(self.StopServer) Maybe move logging of ports to after the ...
4 years, 1 month ago (2016-11-17 17:51:20 UTC) #2
nednguyen
https://codereview.chromium.org/2514473002/diff/1/telemetry/telemetry/internal/util/wpr_server.py File telemetry/telemetry/internal/util/wpr_server.py (right): https://codereview.chromium.org/2514473002/diff/1/telemetry/telemetry/internal/util/wpr_server.py#newcode220 telemetry/telemetry/internal/util/wpr_server.py:220: atexit_with_log.Register(self.StopServer) On 2016/11/17 17:51:20, rnephew (Reviews Here) wrote: > ...
4 years, 1 month ago (2016-11-17 18:25:18 UTC) #3
rnephew (Reviews Here)
https://codereview.chromium.org/2514473002/diff/1/telemetry/telemetry/internal/util/wpr_server.py File telemetry/telemetry/internal/util/wpr_server.py (right): https://codereview.chromium.org/2514473002/diff/1/telemetry/telemetry/internal/util/wpr_server.py#newcode220 telemetry/telemetry/internal/util/wpr_server.py:220: atexit_with_log.Register(self.StopServer) On 2016/11/17 18:25:17, nednguyen wrote: > On 2016/11/17 ...
4 years, 1 month ago (2016-11-17 19:12:56 UTC) #4
nednguyen
lgtm
4 years, 1 month ago (2016-11-17 19:15:57 UTC) #5
rnephew (Reviews Here)
On 2016/11/17 19:15:57, nednguyen wrote: > lgtm Failing under local testing after that change, figuring ...
4 years, 1 month ago (2016-11-17 19:19:37 UTC) #6
rnephew (Reviews Here)
On 2016/11/17 19:19:37, rnephew (Reviews Here) wrote: > On 2016/11/17 19:15:57, nednguyen wrote: > > ...
4 years, 1 month ago (2016-11-17 19:28:07 UTC) #7
nednguyen
lgtm
4 years, 1 month ago (2016-11-17 19:33:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514473002/60001
4 years, 1 month ago (2016-11-17 19:35:24 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 20:00:02 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698