Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 251443005: Revert of Add simple PRESUBMIT check to ensure that all files ending with .json can (Closed)

Created:
6 years, 8 months ago by Yoyo Zhou
Modified:
6 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@git-svn
Visibility:
Public.

Description

Revert of Add simple PRESUBMIT check to ensure that all files ending with .json can (https://codereview.chromium.org/258473002/) Reason for revert: This presubmit rejects existing .json files in the tree that contain comments. (It also doesn't provide enough information about where the json is invalid.) Original issue's description: > Add simple PRESUBMIT check to ensure that all files ending with .json can > be loaded as json. > > R=jochen@chromium.org, maruel@chromium.org > BUG=366395 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265881 TBR=jochen@chromium.org,maruel@chromium.org,iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=366395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Yoyo Zhou
Created Revert of Add simple PRESUBMIT check to ensure that all files ending with .json ...
6 years, 8 months ago (2014-04-24 20:19:20 UTC) #1
Yoyo Zhou
Please check the CQ box if you agree with the reasons here.
6 years, 8 months ago (2014-04-24 20:20:06 UTC) #2
Yoyo Zhou
This invalid check is preventing my CL from passing. I'm going to check the CQ ...
6 years, 8 months ago (2014-04-25 04:51:55 UTC) #3
Yoyo Zhou
The CQ bit was checked by yoz@chromium.org
6 years, 8 months ago (2014-04-25 04:52:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/251443005/1
6 years, 8 months ago (2014-04-25 08:26:03 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 08:26:09 UTC) #6
commit-bot: I haz the power
Failed to apply patch for PRESUBMIT.py: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 8 months ago (2014-04-25 08:26:10 UTC) #7
Yoyo Zhou
6 years, 8 months ago (2014-04-25 15:06:58 UTC) #8
Closing this - need to revert manually, since another change landed on top of
this one.

Powered by Google App Engine
This is Rietveld 408576698