chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java - Issue 251443004: ContentView->ContentViewCore.getContainerView in chrome/ tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java

Issue 251443004: ContentView->ContentViewCore.getContainerView in chrome/ tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/NavigationPopupTest.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillPopupTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java

index 20bd852be6cec74a6f062341c8f80c2d8dee73e5..34d21e1dce4375d12d4761c8e66fdb2137616d3b 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/autofill/AutofillDialogControllerTest.java

@@ -12,7 +12,6 @@ import org.chromium.base.CommandLine;

import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.chrome.shell.ChromeShellTestBase;

-import org.chromium.content.browser.ContentView;

import org.chromium.content.browser.ContentViewCore;

import org.chromium.content.browser.test.util.Criteria;

import org.chromium.content.browser.test.util.CriteriaHelper;

@@ -501,13 +500,13 @@ public class AutofillDialogControllerTest extends ChromeShellTestBase {

setUpAndRequestAutocomplete(url, requestFullBilling, requestShipping, requestPhoneNumbers);

- ContentView view = getActivity().getActiveContentView();

+ final ContentViewCore viewCore = getActivity().getActiveContentViewCore();

assertEquals(actualId + " did not match",

- expected, DOMUtils.getNodeValue(view.getContentViewCore(), actualId));

+ expected, DOMUtils.getNodeValue(viewCore, actualId));

if (requestCcInfo) {

assertEquals("cc-csc did not match",

- TEST_CC_CSC, DOMUtils.getNodeValue(view.getContentViewCore(), "id-opt-cc-csc"));

+ TEST_CC_CSC, DOMUtils.getNodeValue(viewCore, "id-opt-cc-csc"));

}

@@ -518,8 +517,7 @@ public class AutofillDialogControllerTest extends ChromeShellTestBase {

generatePage(requestFullBilling, requestShipping, requestPhoneNumbers),

requestFullBilling, requestShipping, requestPhoneNumbers);

- final ContentView view = getActivity().getActiveContentView();

- final ContentViewCore viewCore = view.getContentViewCore();

+ final ContentViewCore viewCore = getActivity().getActiveContentViewCore();

assertEquals("billing name did not match",

TEST_NAME, DOMUtils.getNodeValue(viewCore, "id-billing-name"));