Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2514423002: Reland of Initial implementation of V8 Top 25 Runtime Stats benchmark (Closed)

Created:
4 years, 1 month ago by fmeawad
Modified:
4 years, 1 month ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, Camillo Bruni
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Initial implementation of V8 Top 25 Runtime Stats benchmark (patchset #1 id:1 of https://codereview.chromium.org/2505283002/ ) Reason for revert: The crash was not due to the benchmark itself, instead it was due to a bug that was another bug that was introduced and fixed while the benchmark was landing. Fix landed at https://codereview.chromium.org/2505813002/ CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Original issue's description: > Revert of Initial implementation of V8 Top 25 Runtime Stats benchmark (patchset #4 id:50001 of https://codereview.chromium.org/2493953002/ ) > > Reason for revert: > Broke telemetry_perf_unittests > > https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1) > https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1) > https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests > > Original issue's description: > > Initial implementation of V8 Top 25 Runtime Stats benchmark > > > > This cl creates a story set of top 25+ V8 website consisting of mostly > > top websites + some use cases the V8 team is interested to track. > > > > This is a migration from an internal benchmark by the V8 team to > > telemetry. It uses the newly created runtimeStatsMetric. > > > > The runtime stats metrics aims at building a breakdown of the time spent > > inside of V8 into the different V8 components. The time and count of > > key functions in V8 is tracked individually, and then grouped by the > > metric into top level V8 groups. > > > > BUG=664318 > > > > Removing the perf CQ try bots. > > > > if this benchmark fails, please contact fmeawad@ first. > > > > Committed: https://crrev.com/014643829588899aed0b7608feea34d8826df8b3 > > Cr-Commit-Position: refs/heads/master@{#432575} > > TBR=nednguyen@google.com,fmeawad@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=664318 > > Committed: https://crrev.com/57fa41b035585407fa354d139dc24ab6ed356a9a > Cr-Commit-Position: refs/heads/master@{#432679} TBR=nednguyen@google.com,dbeam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=664318 Committed: https://crrev.com/a92247e2e3b3904e9717ec590617e83a78a46f47 Cr-Commit-Position: refs/heads/master@{#433977}

Patch Set 1 #

Patch Set 2 : Disable on Android, Windows, and reference build until tested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -0 lines) Patch
M tools/perf/benchmarks/v8.py View 1 1 chunk +59 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/v8_top_25.json View 1 chunk +42 lines, -0 lines 0 comments Download
A tools/perf/page_sets/data/v8_top_25_000.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
A tools/perf/page_sets/v8_top_25.py View 1 chunk +73 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
fmeawad
Created Reland of Initial implementation of V8 Top 25 Runtime Stats benchmark
4 years, 1 month ago (2016-11-21 16:17:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514423002/1
4 years, 1 month ago (2016-11-21 16:19:10 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: winx64_10_perf_cq on master.tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_cq/builds/641)
4 years, 1 month ago (2016-11-21 21:14:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514423002/120001
4 years, 1 month ago (2016-11-22 17:03:55 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:120001)
4 years, 1 month ago (2016-11-22 21:08:23 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 21:10:42 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a92247e2e3b3904e9717ec590617e83a78a46f47
Cr-Commit-Position: refs/heads/master@{#433977}

Powered by Google App Engine
This is Rietveld 408576698