Chromium Code Reviews
DescriptionReland of Initial implementation of V8 Top 25 Runtime Stats benchmark (patchset #1 id:1 of https://codereview.chromium.org/2505283002/ )
Reason for revert:
The crash was not due to the benchmark itself, instead it was due to a bug that was another bug that was introduced and fixed while the benchmark was landing. Fix landed at
https://codereview.chromium.org/2505813002/
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq
Original issue's description:
> Revert of Initial implementation of V8 Top 25 Runtime Stats benchmark (patchset #4 id:50001 of https://codereview.chromium.org/2493953002/ )
>
> Reason for revert:
> Broke telemetry_perf_unittests
>
> https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20(1)
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(1)
> https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests
>
> Original issue's description:
> > Initial implementation of V8 Top 25 Runtime Stats benchmark
> >
> > This cl creates a story set of top 25+ V8 website consisting of mostly
> > top websites + some use cases the V8 team is interested to track.
> >
> > This is a migration from an internal benchmark by the V8 team to
> > telemetry. It uses the newly created runtimeStatsMetric.
> >
> > The runtime stats metrics aims at building a breakdown of the time spent
> > inside of V8 into the different V8 components. The time and count of
> > key functions in V8 is tracked individually, and then grouped by the
> > metric into top level V8 groups.
> >
> > BUG=664318
> >
> > Removing the perf CQ try bots.
> >
> > if this benchmark fails, please contact fmeawad@ first.
> >
> > Committed: https://crrev.com/014643829588899aed0b7608feea34d8826df8b3
> > Cr-Commit-Position: refs/heads/master@{#432575}
>
> TBR=nednguyen@google.com,fmeawad@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=664318
>
> Committed: https://crrev.com/57fa41b035585407fa354d139dc24ab6ed356a9a
> Cr-Commit-Position: refs/heads/master@{#432679}
TBR=nednguyen@google.com,dbeam@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664318
Committed: https://crrev.com/a92247e2e3b3904e9717ec590617e83a78a46f47
Cr-Commit-Position: refs/heads/master@{#433977}
Patch Set 1 #Patch Set 2 : Disable on Android, Windows, and reference build until tested #
Messages
Total messages: 14 (8 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||