Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 25144002: views: Make sure menu checks and submenu arrows have high contrast even when selected. (Closed)

Created:
7 years, 2 months ago by Evan Stade
Modified:
7 years, 2 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org
Visibility:
Public.

Description

views: Make sure menu checks and submenu arrows have high contrast even when selected. BUG=298398 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226416

Patch Set 1 #

Patch Set 2 : relative #

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -36 lines) Patch
M ui/resources/ui_resources.grd View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_config_views.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_image_util.h View 1 chunk +7 lines, -3 lines 0 comments Download
M ui/views/controls/menu/menu_image_util.cc View 2 chunks +35 lines, -21 lines 0 comments Download
M ui/views/controls/menu/menu_item_view.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Evan Stade
7 years, 2 months ago (2013-09-28 00:29:46 UTC) #1
sky
LGTM
7 years, 2 months ago (2013-09-30 15:00:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/25144002/11001
7 years, 2 months ago (2013-09-30 18:03:35 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-09-30 23:34:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/25144002/11001
7 years, 2 months ago (2013-10-01 18:11:53 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-01 18:45:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/25144002/11001
7 years, 2 months ago (2013-10-01 22:18:11 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-01 22:54:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/25144002/11001
7 years, 2 months ago (2013-10-01 23:54:43 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 2 months ago (2013-10-02 00:38:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/25144002/11001
7 years, 2 months ago (2013-10-02 03:28:03 UTC) #11
commit-bot: I haz the power
7 years, 2 months ago (2013-10-02 07:22:13 UTC) #12
Message was sent while issue was closed. 
Change committed as 226416

Powered by Google App Engine
This is Rietveld 408576698