[fullcodegen] Remove deprecated support for lookup variables, eval and with.

src/compiler/ast-graph-builder.h

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_AST_GRAPH_BUILDER_H_
 #define V8_COMPILER_AST_GRAPH_BUILDER_H_
 
 #include "src/ast/ast.h"
 #include "src/compiler/compiler-source-position-table.h"
 #include "src/compiler/js-graph.h"
@@ skipping 244 matching lines @@
 
   // Computes local variable liveness and replaces dead variables in
   // frame states with the undefined values.
   void ClearNonLiveSlotsInFrameStates();
 
   Node** EnsureInputBufferSize(int size);
 
   // Named and keyed loads require a VectorSlotPair for successful lowering.
   VectorSlotPair CreateVectorSlotPair(FeedbackVectorSlot slot) const;
 
-  // Determine which contexts need to be checked for extension objects that
-  // might shadow the optimistic declaration of dynamic lookup variables.
-  uint32_t ComputeBitsetForDynamicGlobal(Variable* variable);
-  uint32_t ComputeBitsetForDynamicContext(Variable* variable);
-
   // Computes the frequency for JSCallFunction and JSCallConstruct nodes.
   float ComputeCallFrequency(FeedbackVectorSlot slot) const;
 
   // ===========================================================================
   // The following build methods all generate graph fragments and return one
   // resulting node. The operand stack height remains the same, variables and
   // other dependencies tracked by the environment might be mutated though.
 
   // Builders to create local function, script and block contexts.
   Node* BuildLocalActivationContext(Node* context);
@@ skipping 45 matching lines @@
                             Handle<Name> name, const VectorSlotPair& feedback);
   Node* BuildKeyedSuperLoad(Node* receiver, Node* home_object, Node* key,
                             const VectorSlotPair& feedback);
 
   // Builders for global variable loads and stores.
   Node* BuildGlobalLoad(Handle<Name> name, const VectorSlotPair& feedback,
                         TypeofMode typeof_mode);
   Node* BuildGlobalStore(Handle<Name> name, Node* value,
                          const VectorSlotPair& feedback);
 
   // Builders for dynamic variable loads and stores.

[Michael Starzinger, 2016/11/23 10:15:48]

nit: Implementation of these two methods is gone, lets also remove the
declaration.

[rmcilroy, 2016/11/23 13:48:51]

Opps, done.

   Node* BuildDynamicLoad(Handle<Name> name, TypeofMode typeof_mode);
   Node* BuildDynamicStore(Handle<Name> name, Node* value);
 
   // Builders for accessing the function context.
   Node* BuildLoadGlobalObject();
   Node* BuildLoadNativeContextField(int index);
 
   // Builders for automatic type conversion.
   Node* BuildToBoolean(Node* input, TypeFeedbackId feedback_id);
   Node* BuildToName(Node* input, BailoutId bailout_id);
@@ skipping 36 matching lines @@
   // The following build methods have the same contract as the above ones, but
   // they can also return {nullptr} to indicate that no fragment was built. Note
   // that these are optimizations, disabling any of them should still produce
   // correct graphs.
 
   // Optimization for variable load from global object.
   Node* TryLoadGlobalConstant(Handle<Name> name);
 
   // Optimization for variable load of dynamic lookup slot that is most likely
   // to resolve to a global slot or context slot (inferred from scope chain).
   Node* TryLoadDynamicVariable(Variable* variable, Handle<String> name,

[Michael Starzinger, 2016/11/23 10:15:48]

nit: Implementation is gone, lets drop the declaration.

[rmcilroy, 2016/11/23 13:48:51]

Done.

                                BailoutId bailout_id,
                                const VectorSlotPair& feedback,
                                OutputFrameStateCombine combine,
                                TypeofMode typeof_mode);
 
   // Optimizations for automatic type conversion.
   Node* TryFastToBoolean(Node* input);
   Node* TryFastToName(Node* input);
 
   // ===========================================================================
@@ skipping 241 matching lines @@
  private:
   SourcePositionTable* const source_positions_;
   SourcePosition const start_position_;
 };
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_AST_GRAPH_BUILDER_H_