[fullcodegen] Remove deprecated support for lookup variables, eval and with.

src/ast/ast-numbering.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/ast/ast-numbering.h"
 
 #include "src/ast/ast.h"
 #include "src/ast/scopes.h"
 
 namespace v8 {
@@ skipping 514 matching lines @@
   node->set_base_id(ReserveIdRange(node->num_ids()));
   for (int i = 0; i < node->values()->length(); i++) {
     Visit(node->values()->at(i));
   }
   node->BuildConstantElements(isolate_);
   ReserveFeedbackSlots(node);
 }
 
 
 void AstNumberingVisitor::VisitCall(Call* node) {
+  if (node->is_possibly_eval()) {
+    DisableFullCodegenAndCrankshaft(kFunctionCallsEval);

[Michael Starzinger, 2016/11/23 10:15:48]

Just out of curiosity, are there cases where this is not covered by the
{scope->calls_eval()} predicate on the overall function literal? Because this
could at first glance indicate a bug in scope analysis.

[rmcilroy, 2016/11/23 13:48:50]

Yeah this didn't work without it. If I remember correctly, it was when an eval
was within a let block scope. The scope->inner_scope_calls_eval() would be set,
but not just scope->calls_eval(). We can't use inner_scope_calls_eval, since
that would also go through function scopes, but I'm assuming the
scope->calls_eval() is only meant to register if that particular scope calls
eval (not inner block or with scopes).

[Michael Starzinger, 2016/11/23 14:11:05]

I briefly talked with Toon about this and he agrees with your assessment and
this is WAI for the scope analysis. I would vote however to remove the check for
{scope->calls_eval()} below in line 593, because it is covered by this new check
and is somewhat confusing IMHO. WDYT?

+  }
   IncrementNodeCount();
   ReserveFeedbackSlots(node);
   node->set_base_id(ReserveIdRange(Call::num_ids()));
   Visit(node->expression());
   VisitArguments(node->arguments());
 }
 
 
 void AstNumberingVisitor::VisitCallNew(CallNew* node) {
   IncrementNodeCount();
@@ skipping 69 matching lines @@
 }
 
 
 bool AstNumbering::Renumber(Isolate* isolate, Zone* zone,
                             FunctionLiteral* function) {
   AstNumberingVisitor visitor(isolate, zone);
   return visitor.Renumber(function);
 }
 }  // namespace internal
 }  // namespace v8