Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2514363002: Revert of [turbofan] Introduce LoadFunctionPrototype simplified operator. (Closed)

Created:
4 years, 1 month ago by Michael Hablich
Modified:
4 years, 1 month ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Introduce LoadFunctionPrototype simplified operator. (patchset #1 id:1 of https://codereview.chromium.org/2517913002/ ) Reason for revert: Blocks roll https://codereview.chromium.org/2517963002/ Original issue's description: > [turbofan] Introduce LoadFunctionPrototype simplified operator. > > Add a LoadFunctionPrototype simplified operator, similar to what > Crankshaft has, that loads the prototype property of a constructor > function. > > R=jarin@chromium.org > BUG=v8:5267 > > Committed: https://crrev.com/1737b2c74b50168e96ef1263def0eb43505fa80c > Cr-Commit-Position: refs/heads/master@{#41127} TBR=jarin@chromium.org,bmeurer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5267 Committed: https://crrev.com/da783fa1ffcec3bd8909071a182c8012b398df96 Cr-Commit-Position: refs/heads/master@{#41141}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -99 lines) Patch
M src/compiler/access-info.h View 3 chunks +0 lines, -3 lines 0 comments Download
M src/compiler/access-info.cc View 4 chunks +3 lines, -17 lines 0 comments Download
M src/compiler/effect-control-linearizer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/compiler/effect-control-linearizer.cc View 2 chunks +0 lines, -47 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/compiler/simplified-operator.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Hablich
Created Revert of [turbofan] Introduce LoadFunctionPrototype simplified operator.
4 years, 1 month ago (2016-11-21 13:31:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514363002/1
4 years, 1 month ago (2016-11-21 13:31:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 13:32:22 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 13:32:49 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da783fa1ffcec3bd8909071a182c8012b398df96
Cr-Commit-Position: refs/heads/master@{#41141}

Powered by Google App Engine
This is Rietveld 408576698