Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 2514353006: DevTools: all swatches get default focused element (reland with fix) (Closed)

Created:
4 years, 1 month ago by luoe
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: all swatches get default focused element (reland with fix) This is a reland of another CL, but with an additional fix: https://codereview.chromium.org/2510883002/ Instead of modifying the color picker's focus logic, this CL simply adds a focus() call for all swatches and sets the default focused element for the other swatch types. BUG=665801 Committed: https://crrev.com/69cc45e5e9b178c78fede5e9c4271aad78847854 Cr-Commit-Position: refs/heads/master@{#434572}

Patch Set 1 #

Patch Set 2 : DevTools: all swatches get default focused element (reland with fix) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/BezierEditor.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/CSSShadowEditor.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SwatchPopoverHelper.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
luoe
This reland doesn't add anything new, but rather subtracts the logic in the first CL ...
4 years, 1 month ago (2016-11-23 02:02:57 UTC) #4
dgozman
lgtm
4 years ago (2016-11-23 22:11:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514353006/20001
4 years ago (2016-11-26 05:27:50 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-26 07:21:37 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-26 07:23:44 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/69cc45e5e9b178c78fede5e9c4271aad78847854
Cr-Commit-Position: refs/heads/master@{#434572}

Powered by Google App Engine
This is Rietveld 408576698