Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 2514353005: Add support for "??" to summaries. (Closed)

Created:
4 years, 1 month ago by Paul Berry
Modified:
4 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
M pkg/analyzer/lib/src/summary/format.fbs View 1 chunk +8 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/link.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_const_expr.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_common.dart View 1 chunk +6 lines, -0 lines 2 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 1 month ago (2016-11-22 17:47:30 UTC) #2
scheglov
LGTM https://codereview.chromium.org/2514353005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (right): https://codereview.chromium.org/2514353005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#newcode2308 pkg/analyzer/test/src/summary/resynthesize_common.dart:2308: const vIfNull = 1 ? 2.0; `1 ?? ...
4 years, 1 month ago (2016-11-22 17:51:38 UTC) #3
Paul Berry
https://codereview.chromium.org/2514353005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart File pkg/analyzer/test/src/summary/resynthesize_common.dart (right): https://codereview.chromium.org/2514353005/diff/1/pkg/analyzer/test/src/summary/resynthesize_common.dart#newcode2308 pkg/analyzer/test/src/summary/resynthesize_common.dart:2308: const vIfNull = 1 ? 2.0; On 2016/11/22 17:51:37, ...
4 years, 1 month ago (2016-11-22 18:02:58 UTC) #4
Paul Berry
4 years, 1 month ago (2016-11-22 18:10:23 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3a6972095fc89fe15fa3b40ee2919730150e34b2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698