Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2514353003:
[Payments] New shipping address should appear in billing address suggest (Closed)
|
Created:
4 years, 1 month ago by sebsg Modified:
4 years, 1 month ago Reviewers:
please use gerrit instead CC:
chromium-reviews, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, agrieve+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Payments] New shipping address should appear in billing address suggest
BUG=667353
Committed: https://crrev.com/4b961830b5d2d1837fb2353374c41d28f02c2086
Cr-Commit-Position: refs/heads/master@{#433595}
Patch Set 1 #
Total comments: 38
Patch Set 2 : Added and used test constants #
Messages
Total messages: 13 (7 generated)
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
sebsg@chromium.org changed reviewers: + rouslan@chromium.org
Hi Rouslan, PTAL?
Thank you for the test! LGTM after my comments. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java (right): https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:62: setSpinnerSelectionsInCardEditorAndWait(new int[] {11, 1, 0}, Please change this to {DECEMBER, NEXT_YEAR, FIRST_BILLING_ADDRESS}, which are now defined in PaymentRequestTestBase. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:66: assertTrue(getSpinnerSelectionTextInCardEditor(2).equals( Please define "private static final int BILLING_ADDRESS_DROPDOWN_INDEX = 2;" and use that everywhere you reference spinner #2. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:84: assertEquals(4, getSpinnerItemCountInCardEditor(2)); BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:102: new int[] {11, 1, ADD_BILLING_ADDRESS}, mReadyToEdit); {DECEMBER, NEXT_YEAR, ADD_BILLING_ADDRESS} https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:109: assertEquals(4, getSpinnerItemCountInCardEditor(2)); BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:125: assertEquals(4, getSpinnerItemCountInCardEditor(2)); BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:128: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 0).equals( BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:130: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 1).equals( BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:132: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 2).equals( BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:134: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 3).equals("Add address")); BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:152: new int[] {11, 1, ADD_BILLING_ADDRESS}, mReadyToEdit); {DECEMBER, NEXT_YEAR, ADD_BILLING_ADDRESS} https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:159: assertEquals(5, getSpinnerItemCountInCardEditor(2)); BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:163: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 0).equals( BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:167: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 1).equals( BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:169: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 2).equals( BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:171: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 3).equals( BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:173: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 4).equals("Add address")); BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:199: assertEquals(5, getSpinnerItemCountInCardEditor(2)); BILLING_ADDRESS_DROPDOWN_INDEX https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:203: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 0).equals( BILLING_ADDRESS_DROPDOWN_INDEX
Thanks! Sending to CQ. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... File chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java (right): https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:62: setSpinnerSelectionsInCardEditorAndWait(new int[] {11, 1, 0}, On 2016/11/21 17:59:16, rouslan wrote: > Please change this to {DECEMBER, NEXT_YEAR, FIRST_BILLING_ADDRESS}, which are > now defined in PaymentRequestTestBase. Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:66: assertTrue(getSpinnerSelectionTextInCardEditor(2).equals( On 2016/11/21 17:59:15, rouslan wrote: > Please define "private static final int BILLING_ADDRESS_DROPDOWN_INDEX = 2;" and > use that everywhere you reference spinner #2. Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:84: assertEquals(4, getSpinnerItemCountInCardEditor(2)); On 2016/11/21 17:59:15, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:102: new int[] {11, 1, ADD_BILLING_ADDRESS}, mReadyToEdit); On 2016/11/21 17:59:16, rouslan wrote: > {DECEMBER, NEXT_YEAR, ADD_BILLING_ADDRESS} Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:109: assertEquals(4, getSpinnerItemCountInCardEditor(2)); On 2016/11/21 17:59:15, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:125: assertEquals(4, getSpinnerItemCountInCardEditor(2)); On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:128: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 0).equals( On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:130: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 1).equals( On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:132: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 2).equals( On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:134: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 3).equals("Add address")); On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:152: new int[] {11, 1, ADD_BILLING_ADDRESS}, mReadyToEdit); On 2016/11/21 17:59:15, rouslan wrote: > {DECEMBER, NEXT_YEAR, ADD_BILLING_ADDRESS} Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:159: assertEquals(5, getSpinnerItemCountInCardEditor(2)); On 2016/11/21 17:59:15, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:163: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 0).equals( On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:167: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 1).equals( On 2016/11/21 17:59:15, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:169: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 2).equals( On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:171: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 3).equals( On 2016/11/21 17:59:15, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:173: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 4).equals("Add address")); On 2016/11/21 17:59:15, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:199: assertEquals(5, getSpinnerItemCountInCardEditor(2)); On 2016/11/21 17:59:16, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done. https://codereview.chromium.org/2514353003/diff/40001/chrome/android/javatest... chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestBillingAddressTest.java:203: assertTrue(getSpinnerTextAtPositionInCardEditor(2, 0).equals( On 2016/11/21 17:59:15, rouslan wrote: > BILLING_ADDRESS_DROPDOWN_INDEX Done.
The CQ bit was checked by sebsg@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org Link to the patchset: https://codereview.chromium.org/2514353003/#ps60001 (title: "Added and used test constants")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1479752512151920,
"parent_rev": "72b85bf29e81a1a02bf74ae92372f0bf0c5cb20d", "commit_rev":
"9bbb296effb5fa26ec12da8f2e549ebac977a417"}
Message was sent while issue was closed.
Committed patchset #2 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== [Payments] New shipping address should appear in billing address suggest BUG=667353 ========== to ========== [Payments] New shipping address should appear in billing address suggest BUG=667353 Committed: https://crrev.com/4b961830b5d2d1837fb2353374c41d28f02c2086 Cr-Commit-Position: refs/heads/master@{#433595} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4b961830b5d2d1837fb2353374c41d28f02c2086 Cr-Commit-Position: refs/heads/master@{#433595} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
