Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2514353002: [parser] Keep track of whether we are in a temp-zone in the parser, and don't lazy parse anymore on… (Closed)

Created:
4 years, 1 month ago by Toon Verwaest
Modified:
4 years, 1 month ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] Keep track of whether we are in a temp-zone in the parser, and don't lazy parse anymore once we are This avoids entering a nested temp zone, and fixes up tracing and runtime callstats names. BUG= Committed: https://crrev.com/768f22f6f6fd1e94efde2aa4fe8c3a5f9de28863 Cr-Commit-Position: refs/heads/master@{#41147}

Patch Set 1 #

Patch Set 2 : also unset of consume but we don't allow lazy #

Patch Set 3 : Move ParsingModeScope to ParseFunction and drop mode from DiscardableZoneScope #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M src/parsing/parser.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/parsing/parser.cc View 1 2 10 chunks +32 lines, -9 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Toon Verwaest
ptal
4 years, 1 month ago (2016-11-21 13:15:22 UTC) #3
marja
lgtm
4 years, 1 month ago (2016-11-21 14:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514353002/40001
4 years, 1 month ago (2016-11-21 14:20:52 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-21 14:58:53 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 14:59:09 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/768f22f6f6fd1e94efde2aa4fe8c3a5f9de28863
Cr-Commit-Position: refs/heads/master@{#41147}

Powered by Google App Engine
This is Rietveld 408576698