Remove redundant 'derived constraint space' setters from NGConstraintSpace

Remove redundant 'derived constraint space' setters from NGConstraintSpace

this is the exact copy of http://crrev.com/2515923002 that was reviewed and submitted. Unfortunately it had to be reverted because of the collision with another LayoutNG patch at the commit time.

Remove
  SetOverflowTriggersScrollbar
  SetFixedSize
  SetFragmentationType
  SetIsNewFormattingContext
  SetSize
  Size
from NGConstraintSpace. Use NGConstraintSpaceBuilder instead.

BUG=635619
Committed: https://crrev.com/df041f08c62f111ea75b36a9ba9bb81260f15233
Cr-Commit-Position: refs/heads/master@{#433608}

[Gleb Lanbin, 2016-11-21 17:33:30]

The CQ bit was checked by glebl@chromium.org to run a CQ dry run

[Gleb Lanbin, 2016-11-21 17:34:12]

glebl@chromium.org changed reviewers:
+ cbiesinger@chromium.org, ikilpatrick@chromium.org

[commit-bot: I haz the power, 2016-11-21 17:34:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ikilpatrick, 2016-11-21 17:45:49]

lgtm

https://codereview.chromium.org/2514343004/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right):

https://codereview.chromium.org/2514343004/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:73: NGPhysicalSize
container_size =
can you also s/container/available in this file?

[Gleb Lanbin, 2016-11-21 18:23:52]

On 2016/11/21 17:45:49, ikilpatrick wrote:
> lgtm
> 
>
https://codereview.chromium.org/2514343004/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc (right):
> 
>
https://codereview.chromium.org/2514343004/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/layout/ng/ng_absolute_utils.cc:73:
NGPhysicalSize
> container_size =
> can you also s/container/available in this file?

if it's more like a nit. fix then I would rather leave it as is. container_size
sounds a bit less ambiguous comparing to available_size. I would rather leave
this decision to the original author of this file.

[commit-bot: I haz the power, 2016-11-21 19:01:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:01:03]

Dry run: This issue passed the CQ dry run.

[Gleb Lanbin, 2016-11-21 19:31:28]

The CQ bit was checked by glebl@chromium.org

[commit-bot: I haz the power, 2016-11-21 19:32:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 19:40:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479756688812690, "parent_rev":
"323ac55a46c6c730f9f83097413243069793a2d8", "commit_rev":
"b3ef67a757ab9ec90253acf0d630b18d8bda3ed6"}

[commit-bot: I haz the power, 2016-11-21 19:41:18]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 19:44:29]

Description was changed from

==========
Remove redundant 'derived constraint space' setters from NGConstraintSpace

this is the exact copy of http://crrev.com/2515923002 that was reviewed and
submitted. Unfortunately it had to be reverted because of the collision with
another LayoutNG patch at the commit time.

Remove
  SetOverflowTriggersScrollbar
  SetFixedSize
  SetFragmentationType
  SetIsNewFormattingContext
  SetSize
  Size
from NGConstraintSpace. Use NGConstraintSpaceBuilder instead.

BUG=635619
==========

to

==========
Remove redundant 'derived constraint space' setters from NGConstraintSpace

this is the exact copy of http://crrev.com/2515923002 that was reviewed and
submitted. Unfortunately it had to be reverted because of the collision with
another LayoutNG patch at the commit time.

Remove
  SetOverflowTriggersScrollbar
  SetFixedSize
  SetFragmentationType
  SetIsNewFormattingContext
  SetSize
  Size
from NGConstraintSpace. Use NGConstraintSpaceBuilder instead.

BUG=635619

Committed: https://crrev.com/df041f08c62f111ea75b36a9ba9bb81260f15233
Cr-Commit-Position: refs/heads/master@{#433608}
==========

[commit-bot: I haz the power, 2016-11-21 19:44:30]

Patchset 1 (id:??) landed as
https://crrev.com/df041f08c62f111ea75b36a9ba9bb81260f15233
Cr-Commit-Position: refs/heads/master@{#433608}