Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: headless/lib/headless_devtools_client_browsertest.cc

Issue 2514343002: Don't silently eat Inspector.TargetCrashed (Closed)
Patch Set: Added a comment Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « headless/lib/browser/headless_devtools_client_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/lib/headless_devtools_client_browsertest.cc
diff --git a/headless/lib/headless_devtools_client_browsertest.cc b/headless/lib/headless_devtools_client_browsertest.cc
index b18fb81f30a9ee13d1e29f1020f018ad7c66f2dd..cce4c045a9e5cbe33ba0a82be1f0231ce212a7ac 100644
--- a/headless/lib/headless_devtools_client_browsertest.cc
+++ b/headless/lib/headless_devtools_client_browsertest.cc
@@ -11,6 +11,7 @@
#include "content/public/test/browser_test.h"
#include "headless/lib/browser/headless_web_contents_impl.h"
#include "headless/public/devtools/domains/emulation.h"
+#include "headless/public/devtools/domains/inspector.h"
#include "headless/public/devtools/domains/network.h"
#include "headless/public/devtools/domains/page.h"
#include "headless/public/devtools/domains/runtime.h"
@@ -661,18 +662,26 @@ class HeadlessDevToolsNavigationControlTest
HEADLESS_ASYNC_DEVTOOLED_TEST_F(HeadlessDevToolsNavigationControlTest);
-class HeadlessCrashObserverTest : public HeadlessAsyncDevTooledBrowserTest {
+class HeadlessCrashObserverTest : public HeadlessAsyncDevTooledBrowserTest,
+ inspector::ExperimentalObserver {
public:
void RunDevTooledTest() override {
+ devtools_client_->GetInspector()->GetExperimental()->AddObserver(this);
+ devtools_client_->GetInspector()->GetExperimental()->Enable(
+ headless::inspector::EnableParams::Builder().Build());
devtools_client_->GetPage()->Enable();
devtools_client_->GetPage()->Navigate(content::kChromeUICrashURL);
}
+ void OnTargetCrashed(const inspector::TargetCrashedParams& params) override {
+ FinishAsynchronousTest();
+ render_process_exited_ = true;
+ }
+
+ // Make sure we don't fail because the renderer crashed!
void RenderProcessExited(base::TerminationStatus status,
int exit_code) override {
EXPECT_EQ(base::TERMINATION_STATUS_ABNORMAL_TERMINATION, status);
- FinishAsynchronousTest();
- render_process_exited_ = true;
}
};
« no previous file with comments | « headless/lib/browser/headless_devtools_client_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698