Don't silently eat Inspector.TargetCrashed

headless/lib/browser/headless_devtools_client_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "headless/lib/browser/headless_devtools_client_impl.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/json/json_reader.h"
@@ skipping 115 matching lines @@
   }
   return true;
 }
 
 bool HeadlessDevToolsClientImpl::DispatchEvent(
     std::unique_ptr<base::Value> owning_message,
     const base::DictionaryValue& message_dict) {
   std::string method;
   if (!message_dict.GetString("method", &method))
     return false;
+  if (method == "Inspector.targetCrashed")
+    renderer_crashed_ = true;
   EventHandlerMap::const_iterator it = event_handlers_.find(method);
   if (it == event_handlers_.end()) {
-    // Silently swallow errors related to the target crashing. This can be
-    // observed via HeadlessWebContents::Observer::RenderProcessExited.
-    if (method == "Inspector.targetCrashed") {
-      renderer_crashed_ = true;
-      return true;
-    }
-
     NOTREACHED() << "Unknown event: " << method;
     return false;
   }
   if (!it->second.is_null()) {
     const base::DictionaryValue* result_dict;
     if (!message_dict.GetDictionary("params", &result_dict)) {
       NOTREACHED() << "Badly formed event parameters";
       return false;
     }
     // DevTools assumes event handling is async so we must post a task here or
@@ skipping 219 matching lines @@
 HeadlessDevToolsClientImpl::Callback::Callback(
     base::Callback<void(const base::Value&)> callback)
     : callback_with_result(callback) {}
 
 HeadlessDevToolsClientImpl::Callback::~Callback() {}
 
 HeadlessDevToolsClientImpl::Callback& HeadlessDevToolsClientImpl::Callback::
 operator=(Callback&& other) = default;
 
 }  // namespace headless