build/sample_arg_file.gn - Issue 2514333005: Add support for customizing GN's args text.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/sample_arg_file.gn

Issue 2514333005: Add support for customizing GN's args text. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Build arguments go here. Here are some of the most commonly set arguments,

	2 # and their default values (as of when `gn args` was run):
	brettw 2016/11/22 16:14:32 I think you you delete this second line. The first I think you you delete this second line. The first line is descriptive enough, and the second line is misleading (is_component_build doesn't default to true if you flip is_debug). If we want to add something else, I'd add: Run "gn args --list <build_dir>" to see available args. Dirk Pranke 2016/11/22 18:41:52 Done. Show quoted text On 2016/11/22 16:14:32, brettw (ping on IM after 24h) wrote: > I think you you delete this second line. The first line is descriptive enough, > and the second line is misleading (is_component_build doesn't default to true if > you flip is_debug). > > If we want to add something else, I'd add: > Run "gn args --list <build_dir>" to see available args. Done.
	3 # is_debug = true

	4 # is_component_build = true

	5 # symbol_level = 2

	6 # use_goma = false
	Dirk Pranke 2016/11/22 04:27:39 This is kind of a dumb file name, but I didn't hav This is kind of a dumb file name, but I didn't have any better ideas, so I'm open to suggestions. I'm also open to suggestions for the contents of this file.
OLD	NEW