Componentize Reading List

ios/chrome/browser/reading_list/BUILD.gn

Index: ios/chrome/browser/reading_list/BUILD.gn
diff --git a/ios/chrome/browser/reading_list/BUILD.gn b/ios/chrome/browser/reading_list/BUILD.gn
index b707a5c56383ec8c26e84242cdf18072c5edb2a6..63552e07c16b344fe6e37ac645825bbc9d992353 100644
--- a/ios/chrome/browser/reading_list/BUILD.gn
+++ b/ios/chrome/browser/reading_list/BUILD.gn
@@ -10,23 +10,8 @@ source_set("reading_list") {
     "reading_list_download_service.h",
     "reading_list_download_service_factory.cc",
     "reading_list_download_service_factory.h",
-    "reading_list_entry.cc",
-    "reading_list_entry.h",
-    "reading_list_model.cc",
-    "reading_list_model.h",
-    "reading_list_model_bridge_observer.h",
-    "reading_list_model_bridge_observer.mm",
     "reading_list_model_factory.cc",
     "reading_list_model_factory.h",
-    "reading_list_model_impl.cc",
-    "reading_list_model_impl.h",
-    "reading_list_model_observer.h",
-    "reading_list_model_storage.h",
-    "reading_list_pref_names.cc",
-    "reading_list_pref_names.h",
-    "reading_list_store.cc",
-    "reading_list_store.h",
-    "reading_list_store_delegate.h",
     "reading_list_web_state_observer.h",
     "reading_list_web_state_observer.mm",
     "url_downloader.cc",
@@ -38,11 +23,12 @@ source_set("reading_list") {
     "//components/keyed_service/ios",
     "//components/pref_registry",
     "//components/prefs",
+    "//components/reading_list",

[sdefresne, 2016/11/21 14:48:31]

Should be in public_deps if any of the header file include one of the
reading_list proto header.

[Olivier, 2016/11/21 15:46:40]

I don't think this is the case

$ git grep -l reading_list.pb.h
components/reading_list/reading_list_entry.cc
components/reading_list/reading_list_entry_unittest.cc
components/reading_list/reading_list_store.cc

+    "//components/reading_list/proto",

[sdefresne, 2016/11/21 14:48:31]

Only required here if one of the .cc or .h file include the proto generated
header.

[Olivier, 2016/11/21 15:46:40]

Done.

     "//components/sync",
     "//components/sync/protocol",
     "//ios/chrome/browser",
     "//ios/chrome/browser/browser_state",
-    "//ios/chrome/browser/reading_list/proto",
     "//ios/web",
     "//net",
     "//url",
@@ -56,20 +42,18 @@ source_set("unit_tests") {
   testonly = true
   sources = [
     "offline_url_utils_unittest.cc",
-    "reading_list_entry_unittest.cc",
-    "reading_list_model_unittest.cc",
-    "reading_list_store_unittest.cc",
     "url_downloader_unittest.cc",
   ]
   deps = [
     ":reading_list",
     "//base",
     "//base/test:test_support",
+    "//components/reading_list",
+    "//components/reading_list/proto",

[sdefresne, 2016/11/21 14:48:31]

ditto

     "//components/sync:test_support_model",
     "//components/sync/protocol",
     "//ios/chrome/browser",
     "//ios/chrome/browser/dom_distiller",
-    "//ios/chrome/browser/reading_list/proto",
     "//ios/web:test_support",
     "//testing/gtest",
     "//url",