Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

Issue 2514333003: Componentize Reading List (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
diff --git a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
index 7c8a9fc926206fb6bcddaff038a96c4bc6727ecc..0bc8a2676ab9477949a7290647882cae2083a781 100644
--- a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
+++ b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
@@ -7,8 +7,9 @@
#import <Foundation/Foundation.h>
#include "base/memory/ptr_util.h"
+#include "components/reading_list/reading_list_model.h"
#include "ios/chrome/browser/browser_state/chrome_browser_state.h"
-#include "ios/chrome/browser/reading_list/reading_list_model.h"
+#include "ios/chrome/browser/reading_list/offline_url_utils.h"
#include "ios/chrome/browser/reading_list/reading_list_model_factory.h"
#include "ios/web/public/navigation_item.h"
#include "ios/web/public/navigation_manager.h"
@@ -118,7 +119,9 @@ void ReadingListWebStateObserver::VerifyIfReadingListEntryStartedLoading() {
if (!entry)
return;
// TODO(crbug.com/664124) Actually load offline pages.
- web::NavigationManager::WebLoadParams params(entry->DistilledURL());
+ GURL distilled_url =
+ reading_list::DistilledURLForPath(entry->DistilledPath());
+ web::NavigationManager::WebLoadParams params(distilled_url);
params.transition_type = ui::PAGE_TRANSITION_AUTO_BOOKMARK;
navigation_manager->LoadURLWithParams(params);
}
« no previous file with comments | « ios/chrome/browser/reading_list/reading_list_store_unittest.cc ('k') | ios/chrome/browser/reading_list/url_downloader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698