Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: ios/chrome/browser/reading_list/reading_list_model_bridge_observer.h

Issue 2514333003: Componentize Reading List (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/reading_list/reading_list_model_bridge_observer.h
diff --git a/ios/chrome/browser/reading_list/reading_list_model_bridge_observer.h b/ios/chrome/browser/reading_list/reading_list_model_bridge_observer.h
index aa7c4f7830a92e098a972f49ef67776e0c0ee03d..25ec2bd8f1cef35f71a8d14c79cc05f642bf2766 100644
--- a/ios/chrome/browser/reading_list/reading_list_model_bridge_observer.h
+++ b/ios/chrome/browser/reading_list/reading_list_model_bridge_observer.h
@@ -1,87 +1,11 @@
-
// Copyright 2016 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef IOS_INTERNAL_CHROME_BROWSER_UI_READING_LIST_READING_LIST_MODEL_BRIDGE_OBSERVER_H_
-#define IOS_INTERNAL_CHROME_BROWSER_UI_READING_LIST_READING_LIST_MODEL_BRIDGE_OBSERVER_H_
-
-#import <Foundation/Foundation.h>
-
-#include "base/macros.h"
-#include "ios/chrome/browser/reading_list/reading_list_model_observer.h"
-
-// Protocol duplicating all Reading List Model Observer methods in Objective-C.
-@protocol ReadingListModelBridgeObserver<NSObject>
-
-@required
-- (void)readingListModelLoaded:(const ReadingListModel*)model;
-- (void)readingListModelDidApplyChanges:(const ReadingListModel*)model;
-
-@optional
-- (void)readingListModel:(const ReadingListModel*)model
- willRemoveUnreadEntryAtIndex:(size_t)index;
-- (void)readingListModel:(const ReadingListModel*)model
- willRemoveReadEntryAtIndex:(size_t)index;
-
-- (void)readingListModel:(const ReadingListModel*)model
- willMoveEntry:(size_t)unreadIndex
- isRead:(BOOL)read;
-
-- (void)readingListModel:(const ReadingListModel*)model
- willAddUnreadEntry:(const ReadingListEntry&)entry;
-- (void)readingListModel:(const ReadingListModel*)model
- willAddReadEntry:(const ReadingListEntry&)entry;
-
-- (void)readingListModelBeganBatchUpdates:(const ReadingListModel*)model;
-- (void)readingListModelCompletedBatchUpdates:(const ReadingListModel*)model;
-
-- (void)readingListModelBeingDeleted:(const ReadingListModel*)model;
-
-- (void)readingListModel:(const ReadingListModel*)model
- willUpdateUnreadEntryAtIndex:(size_t)index;
-- (void)readingListModel:(const ReadingListModel*)model
- willUpdateReadEntryAtIndex:(size_t)index;
-
-@end
-
-// Observer for the Reading List model that translates all the callbacks to
-// Objective-C calls.
-class ReadingListModelBridge : public ReadingListModelObserver {
- public:
- explicit ReadingListModelBridge(id<ReadingListModelBridgeObserver> observer,
- ReadingListModel* model);
- ~ReadingListModelBridge() override;
-
- private:
- void ReadingListModelBeganBatchUpdates(
- const ReadingListModel* model) override;
-
- void ReadingListModelCompletedBatchUpdates(
- const ReadingListModel* model) override;
- void ReadingListModelLoaded(const ReadingListModel* model) override;
- void ReadingListModelBeingDeleted(const ReadingListModel* model) override;
- void ReadingListWillRemoveUnreadEntry(const ReadingListModel* model,
- size_t index) override;
- void ReadingListWillRemoveReadEntry(const ReadingListModel* model,
- size_t index) override;
- void ReadingListWillMoveEntry(const ReadingListModel* model,
- size_t index,
- bool read) override;
- void ReadingListWillAddUnreadEntry(const ReadingListModel* model,
- const ReadingListEntry& entry) override;
- void ReadingListWillAddReadEntry(const ReadingListModel* model,
- const ReadingListEntry& entry) override;
- void ReadingListDidApplyChanges(ReadingListModel* model) override;
- void ReadingListWillUpdateUnreadEntry(const ReadingListModel* model,
- size_t index) override;
- void ReadingListWillUpdateReadEntry(const ReadingListModel* model,
- size_t index) override;
-
- __unsafe_unretained id<ReadingListModelBridgeObserver> observer_;
- ReadingListModel* model_; // weak
+#ifndef IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_BRIDGE_OBSERVER_H_
+#define IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_BRIDGE_OBSERVER_H_
- DISALLOW_COPY_AND_ASSIGN(ReadingListModelBridge);
-};
+// This is a temporary convenience file.
+#include "components/reading_list/reading_list_model_bridge_observer.h"
-#endif // IOS_INTERNAL_CHROME_BROWSER_UI_READING_LIST_READING_LIST_MODEL_BRIDGE_OBSERVER_H_
+#endif // IOS_CHROME_BROWSER_READING_LIST_READING_LIST_MODEL_BRIDGE_OBSERVER_H_

Powered by Google App Engine
This is Rietveld 408576698