[regexp] use C++ API for unicode set over C API.

[regexp] use C++ API for unicode set over C API.

R=jshin@chromium.org

Committed: https://crrev.com/8c4988f73848fc90a89713c20ad7f87dbceb1060
Cr-Commit-Position: refs/heads/master@{#41164}

[jungshik at Google, 2016-11-21 23:41:46]

LGTM with a nit taken care of below.

https://codereview.chromium.org/2514333002/diff/1/src/regexp/regexp-parser.cc
File src/regexp/regexp-parser.cc (right):

https://codereview.chromium.org/2514333002/diff/1/src/regexp/regexp-parser.cc...
src/regexp/regexp-parser.cc:1115: CharacterRange::Range(set.getRangeStart(i),
set.getRangeEnd(i)),
either remove |start| and |end| above or use |start| and |end| here :-)

[Yang, 2016-11-22 06:24:11]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-11-22 06:24:11]

The patchset sent to the CQ was uploaded after l-g-t-m from jshin@chromium.org
Link to the patchset: https://codereview.chromium.org/2514333002/#ps20001
(title: "addressed comment")

[commit-bot: I haz the power, 2016-11-22 06:24:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yang, 2016-11-22 06:24:27]

On 2016/11/21 23:41:46, jungshik at google wrote:
> LGTM with a nit taken care of below.
> 
> https://codereview.chromium.org/2514333002/diff/1/src/regexp/regexp-parser.cc
> File src/regexp/regexp-parser.cc (right):
> 
>
https://codereview.chromium.org/2514333002/diff/1/src/regexp/regexp-parser.cc...
> src/regexp/regexp-parser.cc:1115: CharacterRange::Range(set.getRangeStart(i),
> set.getRangeEnd(i)),
> either remove |start| and |end| above or use |start| and |end| here :-)

Thanks for the review!

[commit-bot: I haz the power, 2016-11-22 07:09:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479795851055430,
"parent_rev": "0d08dfb779cdbbb8240d7de6e38c7a1134c1376a", "commit_rev":
"84f03b7b06580ecdc08509ec125ec8ddd75b73a6"}

[commit-bot: I haz the power, 2016-11-22 07:09:52]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-22 07:10:20]

Description was changed from

==========
[regexp] use C++ API for unicode set over C API.


R=jshin@chromium.org
==========

to

==========
[regexp] use C++ API for unicode set over C API.

R=jshin@chromium.org

Committed: https://crrev.com/8c4988f73848fc90a89713c20ad7f87dbceb1060
Cr-Commit-Position: refs/heads/master@{#41164}
==========

[commit-bot: I haz the power, 2016-11-22 07:10:20]

Patchset 2 (id:??) landed as
https://crrev.com/8c4988f73848fc90a89713c20ad7f87dbceb1060
Cr-Commit-Position: refs/heads/master@{#41164}