Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 251433002: Remove calls to testRunner testRepaint/repaintSweep* (Closed)

Created:
6 years, 8 months ago by enne (OOO)
Modified:
6 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, svillar, jfernandez, Manuel Rego, ojan
Visibility:
Public.

Description

Remove calls to testRunner testRepaint/repaintSweep* These functions are incompatible with force compositing mode and are of dubious value. Also, consolidated all of the shadow-multiple tests into a single test as they are now identical. The fast/repaint/box-shadow-* files are attached to an open bug, so leaving to make it easier to investigate. BUG=366438 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172823

Patch Set 1 #

Patch Set 2 : Add focus-ring expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -259 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +11 lines, -0 lines 0 comments Download
M LayoutTests/fast/css-grid-layout/scrolled-grid-painting-overflow.html View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/repaint/background-clip-text.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/box-shadow-h.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/box-shadow-v.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/flexible-box-overflow.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/flexible-box-overflow-horizontal.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/focus-ring.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/inline-block-overflow.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/layer-child-outline.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/layer-outline.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/layer-outline-horizontal.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/list-marker.html View 1 chunk +2 lines, -3 lines 0 comments Download
A + LayoutTests/fast/repaint/shadow-multiple.html View 1 chunk +2 lines, -2 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-horizontal.html View 1 chunk +0 lines, -27 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-horizontal-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-strict-horizontal.html View 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-strict-horizontal-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-strict-vertical.html View 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-strict-vertical-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-vertical.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/repaint/shadow-multiple-vertical-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/repaint/table-cell-vertical-overflow.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/table-writing-modes-h.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/table-writing-modes-v.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/text-emphasis-h.html View 1 chunk +2 lines, -3 lines 0 comments Download
M LayoutTests/fast/repaint/text-emphasis-v.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/text-shadow.html View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/repaint/text-shadow-horizontal.html View 1 chunk +2 lines, -3 lines 0 comments Download
D LayoutTests/platform/android/fast/repaint/shadow-multiple-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/repaint/shadow-multiple-strict-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/repaint/shadow-multiple-strict-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/android/fast/repaint/shadow-multiple-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/shadow-multiple-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/shadow-multiple-strict-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/shadow-multiple-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac-lion/fast/repaint/shadow-multiple-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/repaint/shadow-multiple-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/repaint/shadow-multiple-strict-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/repaint/shadow-multiple-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-horizontal-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-strict-horizontal-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-strict-horizontal-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-strict-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-strict-vertical-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-vertical-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/repaint/shadow-multiple-vertical-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/svg/repaint/filter-repaint.svg View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
enne (OOO)
I also just set these tests to FCM temporarily to avoid any future rebaselines too.
6 years, 8 months ago (2014-04-24 01:59:33 UTC) #1
abarth-chromium
LGTM assuming these tests are still testing repainting behavior...
6 years, 8 months ago (2014-04-24 14:51:24 UTC) #2
enne (OOO)
Hmm, ok, you make a good point. The problem is that testRepaint() is a giant ...
6 years, 8 months ago (2014-04-24 19:04:00 UTC) #3
enne (OOO)
Er, "if those problems still exist" => "if such test with impl-side painting would have ...
6 years, 8 months ago (2014-04-24 19:07:36 UTC) #4
abarth-chromium
LGTM
6 years, 8 months ago (2014-04-25 23:05:48 UTC) #5
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 8 months ago (2014-04-25 23:08:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/251433002/1
6 years, 8 months ago (2014-04-25 23:08:58 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 23:46:16 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-25 23:46:17 UTC) #9
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 8 months ago (2014-04-26 00:25:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/251433002/1
6 years, 8 months ago (2014-04-26 00:26:09 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-26 01:00:37 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-26 01:00:38 UTC) #13
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-04-28 19:08:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/251433002/1
6 years, 7 months ago (2014-04-28 19:08:59 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 19:42:23 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 7 months ago (2014-04-28 19:42:24 UTC) #17
enne (OOO)
The CQ bit was checked by enne@chromium.org
6 years, 7 months ago (2014-04-28 23:05:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/251433002/20001
6 years, 7 months ago (2014-04-28 23:05:51 UTC) #19
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 03:19:06 UTC) #20
Message was sent while issue was closed.
Change committed as 172823

Powered by Google App Engine
This is Rietveld 408576698