Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(959)

Issue 2514323006: Allow Blink to generate cc::FrameSinkId from RenderThread (Closed)

Created:
4 years, 1 month ago by xlai (Olivia)
Modified:
4 years ago
Reviewers:
kinuko, Fady Samuel, dcheng
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow Blink to generate cc::FrameSinkId from RenderThread This CL allows Blink to use generate cc::FrameSinkId, internally implemented using RenderThread's functions. Currently, Mus is working on making FrameSinkId being able to generated on Renderer process, getting rid of the need of IPC to browser just to get a FrameSinkId. By making this generation function available in Blink, this CL prepares for a refactoring effort on the current OffscreenCanvas.commit() workflow--it would facilitate simplification on CanvasSurfaceLayerBridge that will remove the current sync IPC that relies on the browser process to generate FrameSinkId (which is part of SurfaceId) for it. BUG=664547 Committed: https://crrev.com/2956c331e20ecb5d730d17fdf637ee72b6fd3a6c Cr-Commit-Position: refs/heads/master@{#434535}

Patch Set 1 #

Total comments: 4

Patch Set 2 : change to generateFrameSinkId #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M content/renderer/renderer_blink_platform_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (9 generated)
xlai (Olivia)
4 years, 1 month ago (2016-11-22 19:51:55 UTC) #2
Fady Samuel
https://codereview.chromium.org/2514323006/diff/1/third_party/WebKit/public/platform/Platform.h File third_party/WebKit/public/platform/Platform.h (right): https://codereview.chromium.org/2514323006/diff/1/third_party/WebKit/public/platform/Platform.h#newcode327 third_party/WebKit/public/platform/Platform.h:327: virtual uint32_t getClientId() { return 0; } How about ...
4 years, 1 month ago (2016-11-22 23:41:18 UTC) #5
Fady Samuel
4 years, 1 month ago (2016-11-22 23:41:19 UTC) #6
xlai (Olivia)
https://codereview.chromium.org/2514323006/diff/1/third_party/WebKit/public/platform/Platform.h File third_party/WebKit/public/platform/Platform.h (right): https://codereview.chromium.org/2514323006/diff/1/third_party/WebKit/public/platform/Platform.h#newcode327 third_party/WebKit/public/platform/Platform.h:327: virtual uint32_t getClientId() { return 0; } On 2016/11/22 ...
4 years, 1 month ago (2016-11-22 23:51:55 UTC) #7
kinuko
Platform is a global public layer where all public platform APIs need to go through, ...
4 years ago (2016-11-23 10:33:30 UTC) #8
dcheng
We've intentionally avoided exposing routing IDs to Blink. I'm not sure we should be doing ...
4 years ago (2016-11-23 12:51:41 UTC) #10
xlai (Olivia)
Based on fsamuel@ and kinuko@'s feedback, changing the two functions to become only one specific ...
4 years ago (2016-11-23 15:23:45 UTC) #12
Fady Samuel
On 2016/11/23 15:23:45, xlai (Olivia) wrote: > Based on fsamuel@ and kinuko@'s feedback, changing the ...
4 years ago (2016-11-23 15:29:22 UTC) #13
Fady Samuel
non-OWNER lgtm. This is compatible with the direction we'd like to go in for Mus. ...
4 years ago (2016-11-23 20:58:00 UTC) #14
xlai (Olivia)
Gentle ping to kinuko@..
4 years ago (2016-11-24 03:49:29 UTC) #15
kinuko
lgtm
4 years ago (2016-11-25 09:32:38 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514323006/20001
4 years ago (2016-11-25 16:00:39 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-25 17:46:12 UTC) #21
commit-bot: I haz the power
4 years ago (2016-11-25 17:48:36 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2956c331e20ecb5d730d17fdf637ee72b6fd3a6c
Cr-Commit-Position: refs/heads/master@{#434535}

Powered by Google App Engine
This is Rietveld 408576698