Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2187)

Unified Diff: components/nacl/browser/pnacl_host.h

Issue 2514323004: Convert NaCl renderer-browser messages to mojo. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/nacl/browser/nacl_process_host.cc ('k') | components/nacl/browser/pnacl_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/browser/pnacl_host.h
diff --git a/components/nacl/browser/pnacl_host.h b/components/nacl/browser/pnacl_host.h
index ff3f04eba7da6a4ccab6193dfc2c4f89be0830c5..4956d8d1551abd273dc276efa28e7d8cf08b0855 100644
--- a/components/nacl/browser/pnacl_host.h
+++ b/components/nacl/browser/pnacl_host.h
@@ -34,7 +34,7 @@ class PnaclTranslationCache;
class PnaclHost {
public:
typedef base::Callback<void(base::File)> TempFileCallback;
- typedef base::Callback<void(const base::File&, bool is_hit)> NexeFdCallback;
+ typedef base::Callback<void(base::File, bool is_hit)> NexeFdCallback;
// Gets the PnaclHost singleton instance (creating it if necessary).
// PnaclHost is a singleton because there is only one translation cache, and
@@ -70,9 +70,6 @@ class PnaclHost {
// If the cache request was a miss, the caller is expected to call
// TranslationFinished after it finishes translation to allow the nexe to be
// stored in the cache.
- // The returned temp fd may be closed at any time by PnaclHost, so it should
- // be duplicated (e.g. with IPC::GetPlatformFileForTransit) before the
- // callback returns.
// If |is_incognito| is true, the nexe will not be stored
// in the cache, but the renderer is still expected to call
// TranslationFinished.
« no previous file with comments | « components/nacl/browser/nacl_process_host.cc ('k') | components/nacl/browser/pnacl_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698