Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2514293003: Fixed flaky InkDropImpl death test. (Closed)

Created:
4 years, 1 month ago by bruthig
Modified:
4 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tfarina, bruthig+ink_drop_chromium.org, dcheng
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed flaky InkDropImpl death test. The InkDropImpl.SettingHighlightStateDuringStateExitIsntAllowed test was flaky when run in the views_mus_unittest binary. This CL changes the gtest_death_test_style from "fast" to "threadsafe". BUG=649734 Committed: https://crrev.com/d849facffd977abe85e071a4528f6a6de716042e Cr-Commit-Position: refs/heads/master@{#434279}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into flaky_test #

Patch Set 3 : Merge branch 'master' into flaky_test #

Patch Set 4 : Uncommented the fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M ui/views/animation/ink_drop_impl_unittest.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
bruthig
sadrul@, can you PTAL?
4 years, 1 month ago (2016-11-21 23:50:08 UTC) #4
sadrul
lgtm
4 years, 1 month ago (2016-11-22 02:01:52 UTC) #7
sadrul
https://codereview.chromium.org/2500973002/ is disabling the test. Please merge with tot and re-enable the test with this ...
4 years, 1 month ago (2016-11-22 04:33:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514293003/60001
4 years ago (2016-11-23 21:51:46 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-11-23 23:43:21 UTC) #18
commit-bot: I haz the power
4 years ago (2016-11-23 23:44:41 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d849facffd977abe85e071a4528f6a6de716042e
Cr-Commit-Position: refs/heads/master@{#434279}

Powered by Google App Engine
This is Rietveld 408576698