Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 2514273002: Changed PrintColorAdjust to an enum class and renamed its members (Closed)

Created:
4 years, 1 month ago by sashab
Modified:
4 years, 1 month ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-paint_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, dshwang, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changed PrintColorAdjust to an enum class and renamed its members Changed PrintColorAdjust to an enum class and gave it an unsigned underlying type. Also renamed its members to match its keywords from CSSValueKeywords.in, and removed PrintColorAdjustBits which will be generated. Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to move PrintColorAdjust to be generated in ComputedStyleBase. BUG=628043 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/dfd37d2b7b9be6fcc2da32d58ee83a1bcaad0990 Cr-Commit-Position: refs/heads/master@{#433477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/css/CSSPrimitiveValueMappings.h View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyleConstants.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sashab
4 years, 1 month ago (2016-11-21 03:39:57 UTC) #5
alancutter (OOO until 2018)
lgtm
4 years, 1 month ago (2016-11-21 04:09:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514273002/1
4 years, 1 month ago (2016-11-21 04:23:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-21 05:07:20 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 05:12:25 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfd37d2b7b9be6fcc2da32d58ee83a1bcaad0990
Cr-Commit-Position: refs/heads/master@{#433477}

Powered by Google App Engine
This is Rietveld 408576698