Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2514263004: Add DCHECK() for invalid URL in DeviceManagementService::StartJob() (Closed)

Created:
4 years, 1 month ago by Thiemo Nagel
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add DCHECK() for invalid URL in DeviceManagementService::StartJob() BUG=667710 Committed: https://crrev.com/7ddc6470f6a0dadef7eac16630e8cca4ba795d3f Cr-Commit-Position: refs/heads/master@{#433860}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M components/policy/core/common/cloud/device_management_service.cc View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Thiemo Nagel
Hi Roman, could you please take a look? Thank you, Thiemo
4 years, 1 month ago (2016-11-22 14:40:05 UTC) #5
Roman Sorokin (ftl)
lgtm
4 years, 1 month ago (2016-11-22 14:44:10 UTC) #6
Thiemo Nagel
On 2016/11/22 14:44:10, Roman Sorokin wrote: > lgtm Thank you!
4 years, 1 month ago (2016-11-22 14:51:37 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514263004/1
4 years, 1 month ago (2016-11-22 14:51:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-22 15:14:30 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-22 15:16:13 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ddc6470f6a0dadef7eac16630e8cca4ba795d3f
Cr-Commit-Position: refs/heads/master@{#433860}

Powered by Google App Engine
This is Rietveld 408576698