Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2514263003: Make CPDF_ImageObject::m_Matrix private. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -16 lines) Patch
M core/fpdfapi/edit/cpdf_pagecontentgenerator.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/fpdfapi/font/cpdf_type3char.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_imageobject.h View 1 chunk +3 lines, -1 line 0 comments Download
M core/fpdfapi/page/cpdf_streamcontentparser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M core/fpdfapi/render/fpdf_render_image.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M fpdfsdk/fpdfeditimg.cpp View 1 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Lei Zhang
4 years, 1 month ago (2016-11-21 21:35:30 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/2514263003/diff/1/fpdfsdk/fpdfeditimg.cpp File fpdfsdk/fpdfeditimg.cpp (right): https://codereview.chromium.org/2514263003/diff/1/fpdfsdk/fpdfeditimg.cpp#newcode61 fpdfsdk/fpdfeditimg.cpp:61: pImgObj->set_matrix(matrix); nit: maybe just pImgObj->set_matrix(CFX_Matrix(....))
4 years, 1 month ago (2016-11-21 21:53:01 UTC) #5
Lei Zhang
https://codereview.chromium.org/2514263003/diff/1/fpdfsdk/fpdfeditimg.cpp File fpdfsdk/fpdfeditimg.cpp (right): https://codereview.chromium.org/2514263003/diff/1/fpdfsdk/fpdfeditimg.cpp#newcode61 fpdfsdk/fpdfeditimg.cpp:61: pImgObj->set_matrix(matrix); On 2016/11/21 21:53:00, Tom Sepez wrote: > nit: ...
4 years, 1 month ago (2016-11-21 22:03:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514263003/20001
4 years, 1 month ago (2016-11-21 22:04:19 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 22:54:32 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/8a5e15d7b16c1c2a99b013fc4f68597cedab...

Powered by Google App Engine
This is Rietveld 408576698