Propagates window type properties during aura-mus window creation

ui/aura/test/aura_test_base.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/test/aura_test_base.h"
 
 #include "ui/aura/client/window_parenting_client.h"
+#include "ui/aura/mus/property_utils.h"
 #include "ui/aura/mus/window_tree_client.h"
 #include "ui/aura/mus/window_tree_host_mus.h"
 #include "ui/aura/test/test_window_delegate.h"
 #include "ui/aura/window.h"
 #include "ui/base/ime/input_method_initializer.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/test/material_design_controller_test_api.h"
 #include "ui/compositor/test/context_factories_for_test.h"
 #include "ui/events/event_dispatcher.h"
 #include "ui/events/event_processor.h"
@@ skipping 140 matching lines @@
 }
 
 bool AuraTestBase::OnWmSetProperty(
     Window* window,
     const std::string& name,
     std::unique_ptr<std::vector<uint8_t>>* new_data) {
   return true;
 }
 
 Window* AuraTestBase::OnWmCreateTopLevelWindow(
+    const ui::mojom::WindowType* window_type,
     std::map<std::string, std::vector<uint8_t>>* properties) {
-  return new Window(nullptr);
+  Window* window = new Window(nullptr);
+  if (window_type)

[msw, 2016/11/21 19:26:47]

This seems a bit strange, should we allow a window without a type here? Should
the enums include unknown/invalid to avoid passing ptrs for null?
(ui::wm::WindowType has WINDOW_TYPE_UNKNOWN, but ui::mojom::WindowType doesn't
have one)

[sky, 2016/11/21 22:13:56]

Added UNKNOWN.

+    SetWindowType(window, *window_type);
+  return window;
 }
 
 void AuraTestBase::OnWmClientJankinessChanged(
     const std::set<Window*>& client_windows,
     bool janky) {}
 
 void AuraTestBase::OnWmNewDisplay(
     std::unique_ptr<WindowTreeHostMus> window_tree_host,
     const display::Display& display) {
   // Take ownership of the WindowTreeHost.
@@ skipping 33 matching lines @@
 
 void AuraTestBaseWithType::SetUp() {
   DCHECK(!setup_called_);
   setup_called_ = true;
   ConfigureBackend(GetParam());
   AuraTestBase::SetUp();
 }
 
 }  // namespace test
 }  // namespace aura