core/fpdfapi/page/fpdf_page_func_embeddertest.cpp - Issue 2514173002: Check dimensions and content of bitmaps in EmbedderTests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: core/fpdfapi/page/fpdf_page_func_embeddertest.cpp

Issue 2514173002: Check dimensions and content of bitmaps in EmbedderTests. (Closed)

Patch Set: Fix Mac bots, but will other Macs be happy? Probably. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « BUILD.gn ('k') | core/fpdfapi/parser/fpdf_parser_decode_embeddertest.cpp » ('j') | testing/utils/md5.h » ('J')

OLD	NEW
1 // Copyright 2015 PDFium Authors. All rights reserved.	1 // Copyright 2015 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "testing/embedder_test.h"	5 #include "testing/embedder_test.h"

6 #include "testing/gtest/include/gtest/gtest.h"	6 #include "testing/gtest/include/gtest/gtest.h"

7	7

8 class FPDFPageFuncEmbeddertest : public EmbedderTest {};	8 class FPDFPageFuncEmbeddertest : public EmbedderTest {};

9	9

10 TEST_F(FPDFPageFuncEmbeddertest, Bug_551460) {	10 TEST_F(FPDFPageFuncEmbeddertest, Bug_551460) {

11 // Should not crash under ASan.	11 // Should not crash under ASan.

12 // Tests that the number of inputs is not simply calculated from the domain	12 // Tests that the number of inputs is not simply calculated from the domain

13 // and trusted. The number of inputs has to be 1.	13 // and trusted. The number of inputs has to be 1.

14 EXPECT_TRUE(OpenDocument("bug_551460.pdf"));	14 EXPECT_TRUE(OpenDocument("bug_551460.pdf"));

15 FPDF_PAGE page = LoadPage(0);	15 FPDF_PAGE page = LoadPage(0);

16 EXPECT_NE(nullptr, page);	16 EXPECT_NE(nullptr, page);

17 FPDF_BITMAP bitmap = RenderPage(page);	17 FPDF_BITMAP bitmap = RenderPage(page);

	18 CompareBitmap(bitmap, 612, 792, "1940568c9ba33bac5d0b1ee9558c76b3");
	Tom Sepez 2016/11/21 18:18:25 8 bytes is more than enough, probably don't need f 8 bytes is more than enough, probably don't need full 16 if you want to save some digits.
18 FPDFBitmap_Destroy(bitmap);	19 FPDFBitmap_Destroy(bitmap);

19 UnloadPage(page);	20 UnloadPage(page);

20 }	21 }

OLD	NEW