Fix LabelButton size calculation for non-default fonts.

Fix LabelButton size calculation for non-default fonts.

BUG=666479
Committed: https://crrev.com/27ec4f8bcae25e024776f5f97390f768b5b47f49
Cr-Commit-Position: refs/heads/master@{#433670}

[Evan Stade, 2016-11-19 01:39:44]

estade@chromium.org changed reviewers:
+ msw@chromium.org

[hshi1, 2016-11-19 01:48:34]

hshi@chromium.org changed reviewers:
+ hshi@chromium.org

[hshi1, 2016-11-19 01:48:35]

I can confirm that this fixes the issue on samus. Thanks! LGTM

[Evan Stade, 2016-11-19 02:24:03]

On 2016/11/19 01:48:35, hshi1 wrote:
> I can confirm that this fixes the issue on samus. Thanks! LGTM

Thanks very much for your help in tracking this down.

[msw, 2016-11-19 19:53:38]

lgtm; thanks

[Evan Stade, 2016-11-20 04:09:13]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-11-20 04:09:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Evan Stade, 2016-11-20 04:09:22]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-11-20 04:10:10]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2016-11-20 04:10:11]

+sky for owners

[Evan Stade, 2016-11-20 04:11:38]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-20 04:11:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-20 06:12:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-20 06:12:30]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[sky, 2016-11-21 16:22:55]

LGTM - separate question though, why bother with the cached font list? Seems to
lead to bugs like this.

[Evan Stade, 2016-11-21 20:24:06]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-11-21 20:24:07]

The CQ bit was unchecked by estade@chromium.org

[Evan Stade, 2016-11-21 20:25:24]

On 2016/11/21 16:22:55, sky wrote:
> LGTM - separate question though, why bother with the cached font list? Seems
to
> lead to bugs like this.

in general? I guess it's so we don't have to create a new font list for every
label. Even without that though we'd have to copy the actual label's font list
to the dummy label.

[Evan Stade, 2016-11-21 20:25:29]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2016-11-21 20:26:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-21 22:19:42]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1479759929644000, "parent_rev":
"35e833afcf3b3f6ba6ab65de9eb7fadd9e04b6a9", "commit_rev":
"9764b552febdaec5686d4ea04eb31f47d12c5679"}

[commit-bot: I haz the power, 2016-11-21 22:20:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-21 22:24:25]

Description was changed from

==========
Fix LabelButton size calculation for non-default fonts.

BUG=666479
==========

to

==========
Fix LabelButton size calculation for non-default fonts.

BUG=666479

Committed: https://crrev.com/27ec4f8bcae25e024776f5f97390f768b5b47f49
Cr-Commit-Position: refs/heads/master@{#433670}
==========

[commit-bot: I haz the power, 2016-11-21 22:24:26]

Patchset 1 (id:??) landed as
https://crrev.com/27ec4f8bcae25e024776f5f97390f768b5b47f49
Cr-Commit-Position: refs/heads/master@{#433670}