Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2514143002: [TTS][Overlay] Fix content width overflowing narrow panel. (Closed)

Created:
4 years, 1 month ago by Donn Denman
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

[TTS][Overlay] Fix content width overflowing narrow panel. When the top controls are shown by the Browser, the Overlay Panel gets many onSizeChanged events while the controls animate off the top. This can cause the panel content to overflow a narrow panel on tablet. The panel now ignores the onSizeChanged calls if they have the same height as previous calls. BUG=632483 Review-Url: https://codereview.chromium.org/2486003004 Cr-Commit-Position: refs/heads/master@{#431345} (cherry picked from commit 3f933d51ebdb5027f27e79a9a816857bbdee12ba) Committed: https://chromium.googlesource.com/chromium/src/+/9892b4fa654f59a436144637f5b71c643d0b2f6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/OverlayPanel.java View 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Donn Denman
4 years, 1 month ago (2016-11-19 01:30:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9892b4fa654f59a436144637f5b71c643d0b2f6a.

Powered by Google App Engine
This is Rietveld 408576698