Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js

Issue 2514123002: [Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry (Closed)
Patch Set: changes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
index ebf5b7a00da2f0f5e577d87cf1260f2e95df8e19..866eb2de98b0327bf975ec479fc602e169fe201a 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkDataGridNode.js
@@ -29,6 +29,7 @@
*/
/**
+ * @implements {Network.LogEntry}
* @unrestricted
*/
Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
@@ -259,6 +260,7 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
}
/**
+ * @override
* @return {!SDK.NetworkRequest}
*/
request() {
@@ -266,6 +268,7 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
}
/**
+ * @override
* @return {boolean}
*/
isNavigationRequest() {
@@ -601,3 +604,20 @@ Network.NetworkDataGridNode = class extends UI.SortableDataGridNode {
cellElement.appendChild(subtitleElement);
}
};
+
+/**
+ * @interface
+ */
+Network.LogEntry = function() {};
dgozman 2016/11/21 23:31:26 I did like Network.NetworkLogEntry more.
allada 2016/11/22 00:00:20 Done.
+
+Network.LogEntry.prototype = {
+ /**
+ * @return {!SDK.NetworkRequest}
+ */
+ request() {},
+
+ /**
+ * @return {boolean}
+ */
+ isNavigationRequest() {}
+};

Powered by Google App Engine
This is Rietveld 408576698