[Devtools] Moved NetworkWaterfallColumn to use NetworkLogEntry

third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
@@ skipping 68 matching lines @@
     this._mainRequestLoadTime = -1;
     /** @type {number} */
     this._mainRequestDOMContentLoadedTime = -1;
     this._matchedRequestCount = 0;
     this._highlightedSubstringChanges = [];
 
     /** @type {!Array.<!Network.NetworkLogView.Filter>} */
     this._filters = [];
     /** @type {?Network.NetworkLogView.Filter} */
     this._timeFilter = null;
+    this._hoveredNode = null;
 
     this._currentMatchedRequestNode = null;
     this._currentMatchedRequestIndex = -1;
 
     /** @type {!Components.Linkifier} */
     this.linkifier = new Components.Linkifier();
 
     this._recording = false;
     this._preserveLog = false;
 
@@ skipping 425 matching lines @@
     this._setHoveredNode(node, highlightInitiatorChain);
     this._highlightInitiatorChain((highlightInitiatorChain && node) ? node.request() : null);
   }
 
   _dataGridMouseLeave() {
     this._setHoveredNode(null);
     this._highlightInitiatorChain(null);
   }
 
   /**
-   * @param {?SDK.NetworkRequest} request
+   * @param {?Network.LogEntry} logEntry
    * @param {boolean} highlightInitiatorChain
    */
-  setHoveredRequest(request, highlightInitiatorChain) {
-    this._setHoveredNode(request ? this._nodesByRequestId.get(request.requestId) : null, highlightInitiatorChain);
-    this._highlightInitiatorChain((request && highlightInitiatorChain) ? request : null);
+  setHoveredLogEntry(logEntry, highlightInitiatorChain) {
+    // TODO(allada) Move this into LogEntry/NetworkDataGridNode.
+    this._setHoveredNode(/** @type {?Network.NetworkDataGridNode} */ (logEntry), highlightInitiatorChain);
+    this._highlightInitiatorChain((logEntry && highlightInitiatorChain) ? logEntry.request() : null);
   }
 
   /**
    * @param {?Network.NetworkDataGridNode} node
    * @param {boolean=} highlightInitiatorChain
    */
   _setHoveredNode(node, highlightInitiatorChain) {
     if (this._hoveredNode)
       this._hoveredNode.element().classList.remove('hover');
     this._hoveredNode = node;
     if (this._hoveredNode)
       this._hoveredNode.element().classList.add('hover');
-    this._columns.setHoveredRequest(this._hoveredNode ? this._hoveredNode.request() : null, !!highlightInitiatorChain);
+    this._columns.setHoveredLogEntry(this._hoveredNode, !!highlightInitiatorChain);
   }
 
   /**
    * @param {!Event} event
    */
   _dataGridMouseDown(event) {
     if ((!this._dataGrid.selectedNode && event.button) || event.target.enclosingNodeOrSelfWithNodeName('a'))
       event.consume();
   }
 
@@ skipping 208 matching lines @@
     this._columns.wasShown();
   }
 
   /**
    * @override
    */
   willHide() {
     this._columns.willHide();
   }
 
+  /**
+   * @return {!Network.LogEntry}

[dgozman, 2016/11/21 23:31:27]

Incorrect annotation.

[allada, 2016/11/22 00:00:21]

Done.

+   */
+  nodesList() {

[dgozman, 2016/11/21 23:31:27]

flatNodesList to have the same name everywhere?

[allada, 2016/11/22 00:00:21]

Done.

+    return this._dataGrid.flatNodesList();
+  }
+
   _refresh() {
     this._needsRefresh = false;
 
     if (this._refreshRequestId) {
       this.element.window().cancelAnimationFrame(this._refreshRequestId);
       delete this._refreshRequestId;
     }
 
     this.removeAllNodeHighlights();
 
@@ skipping 914 matching lines @@
   Running: 'running',
   FromCache: 'from-cache'
 };
 
 /** @type {!Array<string>} */
 Network.NetworkLogView._searchKeys =
     Object.keys(Network.NetworkLogView.FilterType).map(key => Network.NetworkLogView.FilterType[key]);
 
 /** @typedef {function(!SDK.NetworkRequest): boolean} */
 Network.NetworkLogView.Filter;