chrome/browser/media_galleries/fileapi/iapps_data_provider.cc - Issue 2514113003: Revert of Require FilePathWatcher destructor to be called in sequence with Watch().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media_galleries/fileapi/iapps_data_provider.cc

Issue 2514113003: Revert of Require FilePathWatcher destructor to be called in sequence with Watch(). (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media_galleries/fileapi/iapps_data_provider.cc

diff --git a/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc b/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc

index 72e90365ceeac4d58d07b4bdafd9f8e8c50685ba..ec8cfd26052ca1382fdf018aeb8bf42a86ed1656 100644

--- a/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc

+++ b/chrome/browser/media_galleries/fileapi/iapps_data_provider.cc

@@ -40,9 +40,7 @@

weak_factory_.GetWeakPtr()));

}

-IAppsDataProvider::~IAppsDataProvider() {

- StopFilePathWatchOnMediaTaskRunner(std::move(library_watcher_));

+IAppsDataProvider::~IAppsDataProvider() {}

bool IAppsDataProvider::valid() const {

return is_valid_;