Dump stack trace on segfault in the VM.

Dump stack trace on segfault in the VM.

Install a signal handler in the standalone VM that dumps a backtrace
similar to what we already do on assertion failures.

For now only Linux and MacOS are supported.

BUG=
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/6cd141def5c02a949d1d9f6e3f7576678f510b93

[Florian Schneider, 2016-11-19 01:20:54]

fschneider@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[kustermann, 2016-11-19 11:14:34]

kustermann@google.com changed reviewers:
+ kustermann@google.com

[kustermann, 2016-11-19 11:14:35]

I would prefer if we don't land this CL.

Due to the recent questions about my stackoverflow/interruption-check CL I
started addressing the remaining concerns (making it work in JIT mode and on
Windows). Since my CL uses SEGV signals, this CL here will get in the way.

If the reason for the CL are crashes on the buildbot, I'd rather ask Bill if we
can enable coredump archiving again.

[siva, 2016-11-21 02:35:06]

On 2016/11/19 11:14:35, kustermann wrote:
> I would prefer if we don't land this CL.
> 
> Due to the recent questions about my stackoverflow/interruption-check CL I
> started addressing the remaining concerns (making it work in JIT mode and on
> Windows). Since my CL uses SEGV signals, this CL here will get in the way.
> 
> If the reason for the CL are crashes on the buildbot, I'd rather ask Bill if
we
> can enable coredump archiving again.

We are trying to figure out the cause for some random SEGVs in google3 test
runs.
Keerti is independently trying to figure out how she could get coredumps from
TAP runs in google3, in the meantime we are trying to get some information show
up in the logs when a SEGV happens in these google3 runs.

[kustermann, 2016-11-21 15:46:21]

> We are trying to figure out the cause for some random SEGVs in google3 test
runs.
> Keerti is independently trying to figure out how she could get coredumps from
> TAP runs in google3, in the meantime we are trying to get some information
show
> up in the logs when a SEGV happens in these google3 runs.

Then just go ahead and land this CL.

[siva, 2016-11-22 06:28:32]

lgtm

https://codereview.chromium.org/2514113002/diff/70001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2514113002/diff/70001/runtime/include/dart_ap...
runtime/include/dart_api.h:3241: *  Print a stack trace. Used for crash
handling.
Print a native stack trace.....

[Florian Schneider, 2016-11-23 18:27:08]

https://codereview.chromium.org/2514113002/diff/70001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2514113002/diff/70001/runtime/include/dart_ap...
runtime/include/dart_api.h:3241: *  Print a stack trace. Used for crash
handling.
On 2016/11/22 06:28:32, siva wrote:
> Print a native stack trace.....

Done.

[Florian Schneider, 2016-11-23 18:27:08]

https://codereview.chromium.org/2514113002/diff/70001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/2514113002/diff/70001/runtime/include/dart_ap...
runtime/include/dart_api.h:3241: *  Print a stack trace. Used for crash
handling.
On 2016/11/22 06:28:32, siva wrote:
> Print a native stack trace.....

Done.

[Florian Schneider, 2016-11-23 18:29:11]

Description was changed from

==========
Dump stack trace on segfault in the VM.

Install a signal handler in the standalone VM that dumps a backtrace
similar to what we already do on assertion failures.

For now only Linux and MacOS are supported.

BUG=
==========

to

==========
Dump stack trace on segfault in the VM.

Install a signal handler in the standalone VM that dumps a backtrace
similar to what we already do on assertion failures.

For now only Linux and MacOS are supported.

BUG=
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6cd141def5c02a949d1d9f6e3f7576678f510b93
==========

[Florian Schneider, 2016-11-23 18:29:12]

Committed patchset #7 (id:110001) manually as
6cd141def5c02a949d1d9f6e3f7576678f510b93 (presubmit successful).