Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2514073002:
media: No longer treat empty robustness differently on ChromeOS (Closed)
Descriptionmedia: No longer treat empty robustness differently on ChromeOS
BUG=482277
Committed: https://crrev.com/6acfc91931dd44aec8585cc265993e2cb4d70c51
Cr-Commit-Position: refs/heads/master@{#433616}
Patch Set 1 #Patch Set 2 : media: Try HW video decoding when robustness is empty on ChromeOS #
Total comments: 2
Patch Set 3 : comments addressed #
Messages
Total messages: 22 (15 generated)
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
xhwang@chromium.org changed reviewers: + ddorwin@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with comment. Also, the current description is a side effect. IMO, the actual change is that we "No longer treat empty robustness differently" (on Chrome OS or any other platform). https://codereview.chromium.org/2514073002/diff/20001/components/cdm/renderer... File components/cdm/renderer/widevine_key_system_properties.cc (right): https://codereview.chromium.org/2514073002/diff/20001/components/cdm/renderer... components/cdm/renderer/widevine_key_system_properties.cc:127: // regardless of the value of |robustness|, even when it's Robustness::EMPTY, EMPTY is not supposed to be special, so there is no need to call it out IMO. Thus, I'd remove " even when it's Robustness::EMPTY,"
Description was changed from ========== media: Try HW video decoding when robustness is empty on ChromeOS BUG=482277 ========== to ========== media: No longer treat empty robustness differently on ChromeOS BUG=482277 ==========
comments addressed
The CQ bit was checked by xhwang@chromium.org to run a CQ dry run
Comments addressed. Thank you! https://codereview.chromium.org/2514073002/diff/20001/components/cdm/renderer... File components/cdm/renderer/widevine_key_system_properties.cc (right): https://codereview.chromium.org/2514073002/diff/20001/components/cdm/renderer... components/cdm/renderer/widevine_key_system_properties.cc:127: // regardless of the value of |robustness|, even when it's Robustness::EMPTY, On 2016/11/18 23:50:07, ddorwin wrote: > EMPTY is not supposed to be special, so there is no need to call it out IMO. > Thus, I'd remove " even when it's Robustness::EMPTY," Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xhwang@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ddorwin@chromium.org Link to the patchset: https://codereview.chromium.org/2514073002/#ps40001 (title: "comments addressed")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1479758114042980,
"parent_rev": "c9951197130f0a0a329f0d2c80d3a5130b2ca81f", "commit_rev":
"6510687fa569d64ee8661776b1997e0c91bc59ae"}
Message was sent while issue was closed.
Description was changed from ========== media: No longer treat empty robustness differently on ChromeOS BUG=482277 ========== to ========== media: No longer treat empty robustness differently on ChromeOS BUG=482277 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== media: No longer treat empty robustness differently on ChromeOS BUG=482277 ========== to ========== media: No longer treat empty robustness differently on ChromeOS BUG=482277 Committed: https://crrev.com/6acfc91931dd44aec8585cc265993e2cb4d70c51 Cr-Commit-Position: refs/heads/master@{#433616} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/6acfc91931dd44aec8585cc265993e2cb4d70c51 Cr-Commit-Position: refs/heads/master@{#433616} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
