Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 2514063002: [post-mortem] JS_API_OBJECT_TYPE and friends (Closed)

Created:
4 years, 1 month ago by fedor.indutny
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[post-mortem] JS_API_OBJECT_TYPE and friends Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE. Exports JSObject::kHeaderSize to ease the inspection of internal fields in llnode. BUG= R=machenbach Committed: https://crrev.com/66611810e13ec2536ec23c35d29330f18390fd20 Cr-Commit-Position: refs/heads/master@{#41157}

Patch Set 1 #

Patch Set 2 : [post-mortem] JS_API_OBJECT_TYPE and friends #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tools/gen-postmortem-metadata.py View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
fedor.indutny
See https://github.com/nodejs/llnode/pull/51 for use-case.
4 years, 1 month ago (2016-11-18 20:40:10 UTC) #3
fedor.indutny
4 years, 1 month ago (2016-11-18 20:40:17 UTC) #4
Michael Achenbach
lgtm
4 years, 1 month ago (2016-11-21 10:26:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2514063002/20001
4 years, 1 month ago (2016-11-21 19:09:27 UTC) #8
fedor.indutny
On 2016/11/21 10:26:27, machenbach (slow) wrote: > lgtm Thank you!
4 years, 1 month ago (2016-11-21 19:09:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-21 19:33:39 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-21 19:34:00 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/66611810e13ec2536ec23c35d29330f18390fd20
Cr-Commit-Position: refs/heads/master@{#41157}

Powered by Google App Engine
This is Rietveld 408576698