Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by fedor.indutny Modified:
4 years, 1 month ago Reviewers:
machenbach, Jakob Kummerow, Michael Achenbach CC:
v8-reviews_googlegroups.com Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[post-mortem] JS_API_OBJECT_TYPE and friends
Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE.
Exports JSObject::kHeaderSize to ease the inspection of internal fields
in llnode.
BUG=
R=machenbach
Committed: https://crrev.com/66611810e13ec2536ec23c35d29330f18390fd20
Cr-Commit-Position: refs/heads/master@{#41157}
Patch Set 1 #Patch Set 2 : [post-mortem] JS_API_OBJECT_TYPE and friends #
Created: 4 years, 1 month ago
Messages
Total messages: 14 (7 generated)
Description was changed from ========== [post-mortem] JS_API_OBJECT_TYPE and friends Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE. Exports JSObject::kHeaderSize to ease the inspection of internal fields in llnode. BUG= ========== to ========== [post-mortem] JS_API_OBJECT_TYPE and friends Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE. Exports JSObject::kHeaderSize to ease the inspection of internal fields in llnode. BUG= R=machenbach ==========
fedor@indutny.com changed reviewers: + jkummerow@chromium.org, machenbach@google.com
See https://github.com/nodejs/llnode/pull/51 for use-case.
machenbach@chromium.org changed reviewers: + machenbach@chromium.org
lgtm
The CQ bit was checked by fedor@indutny.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/11/21 10:26:27, machenbach (slow) wrote: > lgtm Thank you!
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1479755363541640,
"parent_rev": "c4fc1b39d6e206bfd2ba168f985e76f330e987ae", "commit_rev":
"d4d8c3248e430a5b1d36132bbaa698ca9aee4fd6"}
Message was sent while issue was closed.
Description was changed from ========== [post-mortem] JS_API_OBJECT_TYPE and friends Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE. Exports JSObject::kHeaderSize to ease the inspection of internal fields in llnode. BUG= R=machenbach ========== to ========== [post-mortem] JS_API_OBJECT_TYPE and friends Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE. Exports JSObject::kHeaderSize to ease the inspection of internal fields in llnode. BUG= R=machenbach ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [post-mortem] JS_API_OBJECT_TYPE and friends Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE. Exports JSObject::kHeaderSize to ease the inspection of internal fields in llnode. BUG= R=machenbach ========== to ========== [post-mortem] JS_API_OBJECT_TYPE and friends Export JS_API_OBJECT_TYPE, JS_SPECIAL_API_OBJECT_TYPE. Exports JSObject::kHeaderSize to ease the inspection of internal fields in llnode. BUG= R=machenbach Committed: https://crrev.com/66611810e13ec2536ec23c35d29330f18390fd20 Cr-Commit-Position: refs/heads/master@{#41157} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/66611810e13ec2536ec23c35d29330f18390fd20 Cr-Commit-Position: refs/heads/master@{#41157} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
