Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2514053002: Enable SDK summaries with --enable-new-analysis-driver flag. (Closed)

Created:
4 years, 1 month ago by scheglov
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Enable SDK summaries with --enable-new-analysis-driver flag. ...even if the IDEA does not use 'as-is' mode, it should not be a problem in fishfooding. Hopefully a new IDEA will be released before we would want to turn it on for our users. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/4d003da5c84db8b83148f9410bd3cb2f9e1b507b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/server/driver.dart View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 1 month ago (2016-11-18 19:22:54 UTC) #1
Paul Berry
lgtm
4 years, 1 month ago (2016-11-18 19:24:22 UTC) #2
Brian Wilkerson
lgtm
4 years, 1 month ago (2016-11-18 19:24:27 UTC) #3
scheglov
4 years, 1 month ago (2016-11-18 19:32:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d003da5c84db8b83148f9410bd3cb2f9e1b507b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698