Introducing SurfaceReferenceFactory

third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp

Index: third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp b/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp
index 4355caed2a27dd712a886705e5bd9e97539d3cf5..66a224d7d5390766b91440c6aca7d3fdc33a9af7 100644
--- a/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp
+++ b/third_party/WebKit/Source/platform/graphics/CanvasSurfaceLayerBridge.cpp
@@ -6,6 +6,7 @@
 
 #include "cc/layers/surface_layer.h"
 #include "cc/surfaces/surface_id.h"
+#include "cc/surfaces/surface_ref.h"
 #include "cc/surfaces/surface_sequence.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/mojo/MojoHelper.h"
@@ -17,6 +18,25 @@
 
 namespace blink {
 
+namespace {
+
+class SurfaceRef : public cc::SurfaceRefWithSequence<SurfaceRef> {
+ public:
+  SurfaceRef(const mojom::blink::OffscreenCanvasSurfacePtr& m_service)
+      : m_service(m_service) {}
+  void RequireSequence(const cc::SurfaceSequence& seq) override {
+    m_service->Require(id(), seq);
+  }
+  void SatisfySequence(const cc::SurfaceSequence& seq) override {
+    m_service->Satisfy(seq);
+  }
+
+ private:
+  const mojom::blink::OffscreenCanvasSurfacePtr& m_service;
+};
+
+}  // namespace
+
 CanvasSurfaceLayerBridge::CanvasSurfaceLayerBridge(
     mojom::blink::OffscreenCanvasSurfacePtr service)
     : m_service(std::move(service)) {}
@@ -28,16 +48,9 @@ bool CanvasSurfaceLayerBridge::createSurfaceLayer(int canvasWidth,
   if (!m_service->GetSurfaceId(&m_surfaceId))
     return false;
 
-  cc::SurfaceLayer::SatisfyCallback satisfyCallback =
-      convertToBaseCallback(WTF::bind(
-          &CanvasSurfaceLayerBridge::satisfyCallback, WTF::unretained(this)));
-  cc::SurfaceLayer::RequireCallback requireCallback =
-      convertToBaseCallback(WTF::bind(
-          &CanvasSurfaceLayerBridge::requireCallback, WTF::unretained(this)));
-  m_surfaceLayer = cc::SurfaceLayer::Create(std::move(satisfyCallback),
-                                            std::move(requireCallback));
-  m_surfaceLayer->SetSurfaceId(m_surfaceId, 1.f,
-                               gfx::Size(canvasWidth, canvasHeight));
+  cc::SurfaceRefPtr ref(new SurfaceRef(m_service));
+  ref->SetMetadata(m_surfaceId, 1.f, gfx::Size(canvasWidth, canvasHeight));

[Fady Samuel, 2016/11/30 19:51:29]

I really don't like the idea of calling this metadata and make it happen later.
How about making that part of the constructor instead to SurfaceRef?

+  m_surfaceLayer = cc::SurfaceLayer::Create(std::move(ref));
 
   m_webLayer = Platform::current()->compositorSupport()->createLayerFromCCLayer(
       m_surfaceLayer.get());
@@ -45,15 +58,4 @@ bool CanvasSurfaceLayerBridge::createSurfaceLayer(int canvasWidth,
   return true;
 }
 
-void CanvasSurfaceLayerBridge::satisfyCallback(
-    const cc::SurfaceSequence& sequence) {
-  m_service->Satisfy(sequence);
-}
-
-void CanvasSurfaceLayerBridge::requireCallback(
-    const cc::SurfaceId& surfaceId,
-    const cc::SurfaceSequence& sequence) {
-  m_service->Require(surfaceId, sequence);
-}
-
 }  // namespace blink