Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: cc/surfaces/surface_reference_base.h

Issue 2514033002: Introducing SurfaceReferenceFactory (Closed)
Patch Set: c Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surface_reference_base.h
diff --git a/cc/surfaces/surface_reference_base.h b/cc/surfaces/surface_reference_base.h
new file mode 100644
index 0000000000000000000000000000000000000000..608e710d45e9b94afd9a01c26b9472de098c29e1
--- /dev/null
+++ b/cc/surfaces/surface_reference_base.h
@@ -0,0 +1,45 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_SURFACES_SURFACE_REFERENCE_BASE_H_
+#define CC_SURFACES_SURFACE_REFERENCE_BASE_H_
+
+#include <memory>
+
+#include "base/memory/ptr_util.h"
+#include "cc/surfaces/surface_reference_factory.h"
+#include "cc/surfaces/surface_sequence.h"
+
+namespace cc {
+
+class CompositorFrameMetadata;
+class SurfaceReferenceFactory;
+
+// The base class for the references returned by SurfaceReferenceFactory and
+// its subclasses.
+// The objects of this class hold on to their corresponding surface reference
+// until destroy is called.
+// To keep things as lightweight as possible, the base class only keeps a
Fady Samuel 2016/12/14 20:11:39 I wouldn't say it's to keep things lightweight but
Saman Sami 2016/12/14 20:47:52 But more information never hurts flexibility. I ca
+// pointer to the factory and it's up to the subclasses to decide what other
+// information they need to keep.
+class SurfaceReferenceBase {
+ public:
+ explicit SurfaceReferenceBase(
+ scoped_refptr<const SurfaceReferenceFactory> factory);
+ virtual ~SurfaceReferenceBase();
+
+ void Destroy();
+
+ // TODO(fsamuel, samans, kylechar): Remove this.
+ void Destroy(CompositorFrameMetadata* metadata);
+
+ private:
+ scoped_refptr<const SurfaceReferenceFactory> factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(SurfaceReferenceBase);
+};
+
+} // namespace cc
+
+#endif // CC_SURFACES_SURFACE_REFERENCE_BASE_H_

Powered by Google App Engine
This is Rietveld 408576698