Introducing SurfaceReferenceFactory

cc/surfaces/surface_info.h

Index: cc/surfaces/surface_info.h
diff --git a/cc/surfaces/surface_info.h b/cc/surfaces/surface_info.h
new file mode 100644
index 0000000000000000000000000000000000000000..080f7d1f7301cd871b2b4f0ae3d99ec35a36619e
--- /dev/null
+++ b/cc/surfaces/surface_info.h
@@ -0,0 +1,32 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_SURFACES_SURFACE_INFO_H_
+#define CC_SURFACES_SURFACE_INFO_H_
+
+#include "cc/surfaces/surface_id.h"
+#include "ui/gfx/geometry/size.h"
+
+namespace cc {
+
+// This class contains information about the surface that is being embedded.
+struct SurfaceInfo {

[Fady Samuel, 2016/12/12 23:50:58]

I think it would be nice if everything in this struct was read-only to external
accessors.

Basically make this is a class. Make id, scale, and size private with read-only
accessors.

+  SurfaceId id;
+  float scale = 1.f;
+  gfx::Size size;
+
+  SurfaceInfo() = default;
+  SurfaceInfo(const SurfaceId& id, float scale, gfx::Size size)
+      : id(id), scale(scale), size(size) {}
+
+  bool operator==(const SurfaceInfo& info) const {
+    return id == info.id && scale == info.scale && size == info.size;
+  }
+
+  bool operator!=(const SurfaceInfo& info) const { return !(*this == info); }
+};
+
+}  // namespace cc
+
+#endif  // CC_SURFACES_SURFACE_INFO_H_