Introducing SurfaceReferenceFactory

cc/surfaces/surface_embedding.h

+// Copyright (c) 2016 The Chromium Authors. All rights reserved.

[kylechar, 2016/12/08 02:02:46]

No (c) in new copyright headers.

[kylechar, 2016/12/08 02:02:46]

File should have same name as class.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CC_SURFACES_SURFACE_EMBEDDING_H_
+#define CC_SURFACES_SURFACE_EMBEDDING_H_
+
+#include "cc/output/compositor_frame_metadata.h"
+#include "cc/surfaces/surface_embedding_base.h"
+#include "cc/surfaces/surfaces_export.h"
+
+namespace cc {
+
+class CC_SURFACES_EXPORT SurfaceEmbeddingUsingSequence

[Fady Samuel, 2016/12/07 23:29:05]

How about SurfaceSequenceSurfaceEmbedding?

+    : public NON_EXPORTED_BASE(SurfaceEmbedding) {
+ public:
+  explicit SurfaceEmbeddingUsingSequence(const SurfaceInfo& info)
+      : SurfaceEmbedding(info) {}
+
+ private:
+  void DelegateReferenceImpl(CompositorFrameMetadata* metadata) override;
+  void AddReferenceImpl(SurfaceEmbeddingOwner*) override;

[kylechar, 2016/12/08 02:02:46]

SurfaceEmbeddingOwners* owner

+  void RemoveReferenceImpl() override;
+  virtual void RequireSequence(const SurfaceSequence&) = 0;

[kylechar, 2016/12/08 02:02:45]

You should have a virtual destructor for an abstract class.

+  virtual void SatisfySequence(const SurfaceSequence&) = 0;
+  SurfaceSequence seq_;
+};

[kylechar, 2016/12/08 02:02:46]

Again, should this be copyable?

+
+}  // namespace cc
+
+#endif  // CC_SURFACES_SURFACE_EMBEDDING_H_