Introducing SurfaceReferenceFactory

cc/surfaces/surface_reference_base.cc

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "cc/surfaces/surface_reference_base.h"
+
+#include "cc/surfaces/surface_reference_factory.h"
+
+namespace cc {
+
+void SurfaceReferenceBase::Destroy() {
+  if (!factory_)
+    return;

[Fady Samuel, 2016/12/13 22:55:05]

Move this to the destructor:

if (factory_)
  factory_->DestroyReference(this);

[Saman Sami, 2016/12/14 17:50:01]

Done.

+  factory_->DestroyReference(this);
+  factory_ = nullptr;
+}
+
+void SurfaceReferenceBase::Destroy(CompositorFrameMetadata* metadata) {
+  if (!factory_)
+    return;
+  factory_->DestroyReference(this, metadata);
+  factory_ = nullptr;
+}
+
+bool SurfaceReferenceBase::IsDestroyed() const {
+  return factory_ == nullptr;
+}
+
+SurfaceReferenceBase::~SurfaceReferenceBase() {
+  Destroy();
+}
+
+SurfaceReferenceBase::SurfaceReferenceBase(
+    scoped_refptr<const SurfaceReferenceFactory> factory)
+    : factory_(factory) {}

[Fady Samuel, 2016/12/13 22:55:05]

factory_(std::move(factory))

[Saman Sami, 2016/12/14 17:50:01]

Done.

+
+}  // namespace cc