runtime/bin/process_android.cc - Issue 251403004: Mark pipe as close-on-exec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/process_android.cc

Issue 251403004: Mark pipe as close-on-exec. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/process_android.cc

diff --git a/runtime/bin/process_android.cc b/runtime/bin/process_android.cc

index fafd749768a5e79d8721c0ff7873d89c1d7f8a60..1e7c2ada8f86c4c5e8ff6094585aded6cc8edc9f 100644

--- a/runtime/bin/process_android.cc

+++ b/runtime/bin/process_android.cc

@@ -675,7 +675,7 @@ intptr_t Process::SetSignalHandler(intptr_t signal) {

}

if (!found) return -1;

int fds[2];

- if (NO_RETRY_EXPECTED(pipe(fds)) != 0) {

+ if (NO_RETRY_EXPECTED(pipe2(fds, O_CLOEXEC)) != 0) {

return -1;

}

if (!FDUtils::SetNonBlocking(fds[0])) {

« no previous file with comments | « no previous file | runtime/bin/process_linux.cc » ('j') | no next file with comments »