Issue 251403002: Implement an observer for the component updater.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 251403002: Implement an observer for the component updater. (Closed)

Created:
6 years, 8 months ago by Sorin Jianu

Modified:
6 years, 8 months ago

Reviewers:
waffles

CC:
chromium-reviews, cpu_(ooo_6.6-7.5), Shrikant Kelkar

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Implement an observer for the component updater. This change defines and implements and observer for the component update service and refactors the existing code to use it. No new events of features have been added here. More changes will follow to make the observer usable by chrome://components BUG=366388 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266081

Patch Set 1 #

Patch Set 2 : Add asserts. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+335 lines, -279 lines)			Patch
M	chrome/browser/component_updater/component_updater_service.h	View		4 chunks	+48 lines, -35 lines	0 comments	Download
M	chrome/browser/component_updater/component_updater_service.cc	View	1	10 chunks	+44 lines, -38 lines	0 comments	Download
M	chrome/browser/component_updater/test/component_updater_service_unittest.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/component_updater/test/component_updater_service_unittest.cc	View		16 chunks	+239 lines, -201 lines	0 comments	Download
M	chrome/browser/component_updater/test/update_checker_unittest.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sorin@chromium.org/251403002/20001

6 years, 8 months ago (2014-04-24 22:01:37 UTC) #4

Message was sent while issue was closed.

Change committed as 266081

Expand Messages | Collapse Messages