Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2514003002: [DO NOT SUBMIT] Testing a reverted CL to see if changes catch regression. (Closed)

Created:
4 years, 1 month ago by rnephew (Reviews Here)
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews, dshwang, rouslan+autofill_chromium.org, blink-reviews-paint_chromium.org, sebsg+autofillwatch_chromium.org, blink-reviews, jdonnelly+autofillwatch_chromium.org, mathp+autofillwatch_chromium.org, mac-reviews_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DO NOT SUBMIT] Testing a reverted CL to see if changes catch regression. crbug.com/665220 MainFrame scrollbars should work with RFV instead of FV This CL does the following things: - FV::updateScrollbarGeometry and part of FV::computeScrollbarExistence is moved into scrollbar manager. - For MainFrame, the scroller that the scrollbars works with is changed to be RFV from FV - To accommodate for this, a bunch of methods in Scrollbar that used to call into FV now call into RFV, which in turn calls the corresponding methods on its layout viewport. An exception to this is Tickmarks. Tickmarks for MainFrame are now stored in RFV. - The isOverlayScrollbar method was needlessly implemented in FV. This CL removes this. BUG=456861 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/322db3d6f1f9eb4b9cd6a0054999718c24b1f076 Cr-Commit-Position: refs/heads/master@{#431683} patch from issue 2454913003 at patchset 350001 (http://crrev.com/2454913003#ps350001)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -194 lines) Patch
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-iframe-window.html View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/transforms/selection-bounds-in-transformed-view.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/window-resize-centered-inline-under-fixed-pos-expected.txt View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/paint/invalidation/window-resize-vertical-writing-mode-expected.txt View 2 chunks +12 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.h View 4 chunks +7 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 9 chunks +65 lines, -53 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.h View 2 chunks +28 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RootFrameViewport.cpp View 2 chunks +85 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarManager.h View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollbarManager.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.h View 7 chunks +21 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 55 chunks +122 lines, -63 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698