Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2513993002: [ObjC ARC] Converts ios/chrome/browser/metrics:unit_tests to ARC.Automatically generated ARCMigra… (Closed)

Created:
4 years, 1 month ago by stkhapugin
Modified:
4 years ago
Reviewers:
sdefresne
CC:
chromium-reviews, pkl (ping after 24h if needed), mac-reviews_chromium.org, asvitkine+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/metrics:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Committed: https://crrev.com/48471ab0ba208086377107b1462583c504365aa4 Cr-Commit-Position: refs/heads/master@{#436286}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ios/chrome/browser/metrics/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M ios/chrome/browser/metrics/previous_session_info_unittest.mm View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
stkhapugin
PTAL. Passes downstream tests
4 years ago (2016-11-24 17:07:26 UTC) #6
sdefresne
lgtm
4 years ago (2016-11-24 17:26:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2513993002/1
4 years ago (2016-12-05 13:25:56 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-05 14:32:27 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-05 14:35:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48471ab0ba208086377107b1462583c504365aa4
Cr-Commit-Position: refs/heads/master@{#436286}

Powered by Google App Engine
This is Rietveld 408576698